-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.2] Update dependencies #6377
Conversation
This reverts commit 76ce2dd.
Contributes to dotnet#6380
@@ -90,7 +90,7 @@ protected override IAzureClientBuilder<AzureOpenAIClient, AzureOpenAIClientOptio | |||
|
|||
if (!string.IsNullOrEmpty(settings.Key)) | |||
{ | |||
var credential = new AzureKeyCredential(settings.Key); | |||
var credential = new ApiKeyCredential(settings.Key); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working around a binary breaking change between beta versions of System.ClientModel 1.1.0. See Azure/azure-sdk-for-net#45554. The Azure.AI.OpenAI 2.0.0-beta5 version we are using was using that implicit operator, which is no longer there in the released 1.1.0 GA version. Using the ApiKeyCredential directly side-steps the implicit operator break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hopefully CI passes someday.
@joperezr - looks like this needs 2 approvals. |
Thanks for the help pushing this through |
Updating NuGet and docker dependencies to latest.
Microsoft Reviewers: Open in CodeFlow