Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Npgsql Metrics #658

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Fix Npgsql Metrics #658

merged 3 commits into from
Nov 2, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Nov 2, 2023 •
edited
Loading

prepared ratio for Npgsql was missed in #648

Addresses #645

Also, Npgsql's histograms are in seconds, not milliseconds. We need an explicit bucket for this to work.

Fix #641

@eerhardt
Restore disabled counter
12eb975 
This was missed in #648

Addresses #645
@JamesNK
Copy link
Member

JamesNK commented Nov 2, 2023

Needs to be backported to p1.

@eerhardt eerhardt enabled auto-merge (squash) November 2, 2023 13:54
@eerhardt eerhardt disabled auto-merge November 2, 2023 14:01
@eerhardt eerhardt changed the title Restore disabled counter Fix Npgsql Metrics Nov 2, 2023
@eerhardt eerhardt requested a review from davidfowl November 2, 2023 14:10
@eerhardt
Copy link
Member Author

eerhardt commented Nov 2, 2023

The command duration and create_time metrics now make sense:

image

image

JamesNK
JamesNK approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eerhardt eerhardt enabled auto-merge (squash) November 2, 2023 14:27
@eerhardt eerhardt merged commit 314af0f into main Nov 2, 2023
5 checks passed
@eerhardt eerhardt deleted the RestoreDisabledInstrument branch November 2, 2023 14:31
eerhardt added a commit that referenced this pull request Nov 2, 2023
@eerhardt
Fix Npgsql Metrics (#658)
3350d87 
* Restore disabled counter

This was missed in #648

Addresses #645

* Add view to Npgsql's histograms because they are in seconds and not ms.

Fix #641
joperezr pushed a commit that referenced this pull request Nov 2, 2023
@eerhardt
Fix Npgsql Metrics (#658) (#660)
ff558bb 
* Restore disabled counter

This was missed in #648

Addresses #645

* Add view to Npgsql's histograms because they are in seconds and not ms.

Fix #641
@danmoseley danmoseley added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@davidfowl davidfowl davidfowl approved these changes

@sebastienros sebastienros Awaiting requested review from sebastienros sebastienros is a code owner

@tlmii tlmii Awaiting requested review from tlmii

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add view to Npgsql duration metrics
4 participants
@eerhardt @JamesNK @davidfowl @danmoseley