Refine service reference warnings and errors #13184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #12792 - client: - add error if OpenAPI file does not exist - separate unsupported TFM case from targets being called when disabled - server: - generalize multi-targeting handling in Microsoft.Extensions.ApiDescription.Server - add `$(_OpenApiGenerateDocumentsTFM)`, the TFM used when invoking inner build - default `$(OpenApiGenerateDocuments)` to 'true' only when a supported TFM exists - add separate error for non-existent cache file in `OpenApiGetDocuments` target - add error in `GetDocumentInsider` if no documents are found - make `<Warning />` in the targets file an `<Error />` - add more text to existing `ServiceNotFound` error - both: - write errors to `stderr` - clean up top-level output for `Exception`s - stop writing the `Message` twice * Correct "Open API" mentions; should be "OpenAPI" - change package tags and comments * Add service reference projects to MvcNoDeps.slnf nits: - add "service reference" tag in Microsoft.Extensions.ApiDescription.* packages - add "document generation" tag in Microsoft.Extensions.ApiDescription.Server package - `.Trim()` TFM properties because `<TargetFrameworks>;netcoreapp3.0;;</TargetFrameworks>` is allowed - don't use bold black for verbose messages - reorder MSBuild property settings for readability
|
/bump reviewers. All checks passed. |
pranavkm
approved these changes
Aug 16, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(_OpenApiGenerateDocumentsTFM), the TFM used when invoking inner build$(OpenApiGenerateDocuments)to 'true' only when a supported TFM existsOpenApiGetDocumentstargetGetDocumentInsiderif no documents are found<Warning />in the targets file an<Error />ServiceNotFounderrorstderrExceptionsMessagetwiceCorrect "Open API" mentions; should be "OpenAPI"
Add service reference projects to MvcNoDeps.slnf
nits:
.Trim()TFM properties because<TargetFrameworks>;netcoreapp3.0;;</TargetFrameworks>is allowed