Add tests of client code generation components #13444
Conversation
- #4914 - include tests of tasks - include test project that builds and can be tested in the future
|
@Pilchie are test-only changes in 'release/3.0' ask or tell mode? |
| @@ -0,0 +1,183 @@ | |||
| { | |||
There was a problem hiding this comment.
The JSON files in this directory aren't particularly interesting. Suggest just marking them as Viewed.
| @@ -23,22 +23,18 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.dotnet-openapi", | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "dotnet-microsoft.openapi.Tests", "Microsoft.dotnet-openapi\test\dotnet-microsoft.openapi.Tests.csproj", "{26BBA8A7-0F69-4C5F-B1C2-16B3320FFE3F}" | |||
| EndProject | |||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Extensions.ApiDescription.Client", "Extensions.ApiDescription.Client", "{78610083-1FCE-47F5-AB4D-AF0E1313B351}" | |||
There was a problem hiding this comment.
Not sure when the hierarchy got changed but I moved the service ref projects to match.
|
Tell mode is fine for test only changes. |
dougbu
added
tell-mode
Pilchie
added
the
area-mvc
- add `MockBuildEngine` class to support tests where MSBuild task logs - correct an incredibly minor issue related to logging errors for `@(OpenApiProjectReference)` items - set `%(SourceProject)` metadata and use it when logging nit: use `SortedDictionary<string, string>` everwhere
| @@ -48,7 +48,9 @@ | |||
| </MSBuild> | |||
|
|
|||
| <ItemGroup> | |||
| <OpenApiReference Include="@(_Temporary)" Exclude="@(OpenApiReference)" RemoveMetadata="FullConfiguration" /> | |||
| <OpenApiReference Include="@(_Temporary)" Exclude="@(OpenApiReference)" RemoveMetadata="FullConfiguration"> | |||
| <SourceProject>%(_Temporary.OriginalItemSpec)</SourceProject> | |||
There was a problem hiding this comment.
This looks like a change to the source. Does this need ask mode approval?
There was a problem hiding this comment.
It's teensy but I defer to @Pilchie w.r.t ask mode.
As mentioned in my description, this only affects logging of an error related to @(OpenApiProjectReference) items. %(OriginalItemSpec) metadata would be a viable alternative in GetOpenApiReferenceMetadata but %(SourceProject) is nice to have later because %(OriginalItemSpec) will exist in all items that task produces.
|
hit again by a marked-flaky test running in main build |
ghost
deleted the
Description
Test-only change to add tests of Microsoft.Extensions.ApiDescription.Client package
Customer impact
Increased confidence we're shipping something that works
Regression
no
Risk
Minimal. The tests are designed to work reliably and cross-platform.