Optimize namespace comparisons #17119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #16922 Improves the performance significantly by avoiding allocations for the purpose of comparing the namespace.
rynowak
commented
Nov 15, 2019
src/Components/Analyzers/src/ComponentInternalUsageDiagnosticAnalzyer.cs
Outdated
Show resolved
Hide resolved
rynowak
commented
Nov 15, 2019
| @@ -27,17 +30,25 @@ public ComponentInternalUsageDiagnosticAnalyzer() | |||
|
|
|||
| public override void Initialize(AnalysisContext context) | |||
| { | |||
| context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics); | |||
There was a problem hiding this comment.
I wanted this to be explicit so it's clear that we mean to do it.
rynowak
commented
Nov 15, 2019
| @@ -40,6 +40,7 @@ public void Register(AnalysisContext context) | |||
| context.RegisterOperationAction( | |||
| AnalyzeOperation, | |||
| OperationKind.ObjectCreation, | |||
| OperationKind.Invocation, | |||
There was a problem hiding this comment.
This was part of my previous PR. I'm not sure how it got left out? 🤷♂
|
Before
After
|
|
This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com. I've triaged the above build. I've created/commented on the following issue(s) |
pranavkm
approved these changes
Nov 15, 2019
src/Components/Analyzers/src/ComponentInternalUsageDiagnosticAnalzyer.cs
Outdated
Show resolved
Hide resolved
src/Components/Analyzers/src/ComponentInternalUsageDiagnosticAnalzyer.cs
Outdated
Show resolved
Hide resolved
…nalzyer.cs Co-Authored-By: Pranav K <prkrishn@hotmail.com>
|
@pranavkm - good catch |
Pilchie
approved these changes
Nov 15, 2019
JamesNK
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16922
Improves the performance significantly by avoiding allocations for the
purpose of comparing the namespace.