Update static HTML with name ASP.NET Core Module instead of ANCM #18346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
requested review from
analogrelay,
halter73 and
Tratcher
as code owners
ghost
added
the
analogrelay
reviewed
Jan 15, 2020
There was a problem hiding this comment.
You have opened Pandora's @anurse's Box of wOrDsMiThErY!
Some suggestions, though I could be swayed either way on most.
- "ASP.NET Core Module" is still pretty esoteric and not what most users interact with IMO
- Title Case In Error Messages Annoys Me. Just use normal sentence casing, with proper nouns like ASP.NET Core capitalized.
- The word "app" is good enough for docs, so it's good enough for me
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/HandlerResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HostFxrResolver.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/dllmain.cpp
Outdated
Show resolved
Hide resolved
Co-Authored-By: Andrew Stanton-Nurse <andrew@stanton-nurse.com>
davidfowl
reviewed
Jan 16, 2020
|
Tests passed: https://dev.azure.com/dnceng/public/_build/results?buildId=488024&view=ms.vss-test-web.build-test-results-tab. @anurse can you hit me with an approval 😄 |
analogrelay
approved these changes
Jan 21, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion by @RickStrahl on twitter. ANCM isn't clear what it is referring to.
There will probably be a few tests to shake out as I didn't run tests locally.