Sync shared code from runtime #19328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
Tratcher
requested changes
Feb 25, 2020
| @@ -143,6 +143,12 @@ static MsQuicApi() | |||
|
|
|||
| OperatingSystem ver = Environment.OSVersion; | |||
|
|
|||
| if (ver.Platform == PlatformID.Win32NT && ver.Version < new Version(10, 0, 19041, 0)) | |||
There was a problem hiding this comment.
Justin, I didn't realize you'd removed this in aspnet. This PR won't work then. I'll keep it long enough to figure out the CLA, but go ahead and merge your other PR.
|
@anurse thoughts on the CLA bot? |
|
@Tratcher not sure. I suppose Maestro has to get around it too. |
|
CLA has been cleared! Closing this PR as out of date. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to sync shared code changes from runtime. Fixes #18943