Make connection options parsing "safe" #21004

benaadams · 2020-04-20T02:34:35Z

Contributes to #4720

Starting PR run on '35b259753593be3e9a911b8d936348c0d4a38771'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 352,614 |      99 |          92 |              6.61 |          516 |           27019 |              120355 |             161.88 |         0.58 |      0 |  1.00 |
|       After | 356,683 |      99 |          90 |              6.48 |          494 |            7506 |              120355 |             129.31 |         0.78 |      0 |  1.01 |

benaadams · 2020-04-20T02:35:18Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-20T02:35:25Z

Starting 'Default' pipelined plaintext benchmark with session ID '715a1c6bbe6145c38fbd64c042e8e22c'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-20T02:39:57Z

Baseline

Starting baseline run on '2d7238601c4d5894fd6f2cd68cce8e24967ef994'...
RequestsPerSecond:           342,994
Max CPU (%):                 99
WorkingSet (MB):             88
Avg. Latency (ms):           6.71
Startup (ms):                511
First Request (ms):          160.31
Latency (ms):                0.46
Total Requests:              5,178,484
Duration: (ms)               15,100
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             27,023
Published Size (KB):         120,299
SDK:                         5.0.100-preview.2.20120.3
Runtime:                     5.0.0-preview.4.20218.1
ASP.NET Core:                5.0.0-preview.4.20218.5

PR

Starting PR run on '59215918e90c863b3e78e02417efc9c266de9077'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 342,994 |      99 |          88 |              6.71 |          511 |           27023 |              120299 |             160.31 |         0.46 |      0 |  1.00 |
|       After | 346,571 |      99 |          88 |              6.72 |          487 |            7511 |              120299 |             130.97 |         0.78 |      0 |  1.01 |

benaadams · 2020-04-23T04:02:10Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-23T04:05:27Z

Starting 'Default' pipelined plaintext benchmark with session ID '6956c934428d4280ab7f200bf6ae765e'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-23T04:09:46Z

Baseline

Starting baseline run on '38577e85ce7edee13c907c4bd778f2ca267e6ee8'...
RequestsPerSecond:           342,428
Max CPU (%):                 99
WorkingSet (MB):             90
Avg. Latency (ms):           6.8
Startup (ms):                503
First Request (ms):          153.82
Latency (ms):                0.64
Total Requests:              5,170,525
Duration: (ms)               15,100
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             64,520
Published Size (KB):         120,355
SDK:                         5.0.100-preview.2.20120.3
Runtime:                     5.0.0-preview.5.20221.15
ASP.NET Core:                5.0.0-preview.5.20222.8

PR

Starting PR run on 'd5166aba42e657a00c3bc519ffb8f6ebb3ad993a'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 342,428 |      99 |          90 |               6.8 |          503 |           64520 |              120355 |             153.82 |         0.64 |      0 |  1.00 |
|       After | 341,161 |      99 |          90 |              6.76 |          485 |            7502 |              120355 |              121.6 |         0.93 |      0 |  1.00 |

benaadams · 2020-04-23T12:09:33Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-23T12:10:26Z

Starting 'Default' pipelined plaintext benchmark with session ID 'b27aa4bd605b42ec983ea44c9924b378'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-23T12:12:42Z

Baseline

stdout: Starting baseline run on '38577e85ce7edee13c907c4bd778f2ca267e6ee8'...
The specified client url 'http://127.0.0.1:5002' is invalid or not responsive.


stderr: Baseline benchmark run on '38577e85ce7edee13c907c4bd778f2ca267e6ee8' failed.

PR

benaadams · 2020-04-23T15:50:32Z

Raised issue for some redundant checks the Jit does dotnet/runtime#35348

benaadams · 2020-04-23T15:50:41Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-23T15:52:14Z

Starting 'Default' pipelined plaintext benchmark with session ID 'e8fb684c82c34179afeff44d7354da37'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-23T15:56:02Z

Baseline

Starting baseline run on '38577e85ce7edee13c907c4bd778f2ca267e6ee8'...
RequestsPerSecond:           352,614
Max CPU (%):                 99
WorkingSet (MB):             92
Avg. Latency (ms):           6.61
Startup (ms):                516
First Request (ms):          161.88
Latency (ms):                0.58
Total Requests:              5,324,289
Duration: (ms)               15,100
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             27,019
Published Size (KB):         120,355
SDK:                         5.0.100-preview.2.20120.3
Runtime:                     5.0.0-preview.5.20221.15
ASP.NET Core:                5.0.0-preview.5.20223.1

PR

Starting PR run on '35b259753593be3e9a911b8d936348c0d4a38771'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 352,614 |      99 |          92 |              6.61 |          516 |           27019 |              120355 |             161.88 |         0.58 |      0 |  1.00 |
|       After | 356,683 |      99 |          90 |              6.48 |          494 |            7506 |              120355 |             129.31 |         0.78 |      0 |  1.01 |

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs

benaadams · 2020-04-24T23:23:49Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-24T23:25:25Z

Starting 'Default' pipelined plaintext benchmark with session ID '93ad8b7cf01d4f43a926eede6f332a85'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-24T23:29:44Z

Baseline

Starting baseline run on '38577e85ce7edee13c907c4bd778f2ca267e6ee8'...
RequestsPerSecond:           344,780
Max CPU (%):                 99
WorkingSet (MB):             86
Avg. Latency (ms):           6.68
Startup (ms):                487
First Request (ms):          157.28
Latency (ms):                0.41
Total Requests:              5,200,114
Duration: (ms)               15,080
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             29,008
Published Size (KB):         120,383
SDK:                         5.0.100-preview.2.20120.3
Runtime:                     5.0.0-preview.5.20223.1
ASP.NET Core:                5.0.0-preview.5.20223.13

PR

Starting PR run on 'c0ddcd302263ac8159251f4c68a4d61ea3f5ca69'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 344,780 |      99 |          86 |              6.68 |          487 |           29008 |              120383 |             157.28 |         0.41 |      0 |  1.00 |
|       After | 336,054 |      99 |          88 |              6.92 |          489 |            7503 |              120383 |             132.11 |         0.69 |      0 |  0.97 |

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs

benaadams · 2020-04-25T10:59:47Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-25T11:01:11Z

Starting 'Default' pipelined plaintext benchmark with session ID '85ef06608bea4fd3864b6725e3401228'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-25T11:04:25Z

Baseline

Starting baseline run on '3d034feef860002ff53ed70f56d7d11301763293'...
RequestsPerSecond:           346,907
Max CPU (%):                 99
WorkingSet (MB):             92
Avg. Latency (ms):           6.71
Startup (ms):                478
First Request (ms):          132.07
Latency (ms):                0.76
Total Requests:              5,236,275
Duration: (ms)               15,090
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             10,004
Published Size (KB):         120,383
SDK:                         5.0.100-preview.2.20120.3
Runtime:                     5.0.0-preview.5.20223.1
ASP.NET Core:                5.0.0-preview.5.20223.13

PR

Starting PR run on 'd6eacd443c7e83dd11ffef129101bccc8027f054'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 346,907 |      99 |          92 |              6.71 |          478 |           10004 |              120383 |             132.07 |         0.76 |      0 |  1.00 |
|       After | 349,939 |      99 |          90 |              6.61 |          511 |            7503 |              120383 |             151.09 |         0.55 |      0 |  1.01 |

benaadams · 2020-04-25T14:14:15Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-25T14:15:27Z

Starting 'Default' pipelined plaintext benchmark with session ID 'd28ca040955242bbbe01601bb8678e74'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-25T14:19:43Z

Baseline

Starting baseline run on '3d034feef860002ff53ed70f56d7d11301763293'...
RequestsPerSecond:           351,551
Max CPU (%):                 99
WorkingSet (MB):             90
Avg. Latency (ms):           6.64
Startup (ms):                474
First Request (ms):          169.11
Latency (ms):                0.54
Total Requests:              5,308,453
Duration: (ms)               15,100
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             28,511
Published Size (KB):         120,383
SDK:                         5.0.100-preview.2.20120.3
Runtime:                     5.0.0-preview.5.20223.1
ASP.NET Core:                5.0.0-preview.5.20223.13

PR

Starting PR run on '0632ea1b812bfced5eadcd704f95d605ab266e97'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 351,551 |      99 |          90 |              6.64 |          474 |           28511 |              120383 |             169.11 |         0.54 |      0 |  1.00 |
|       After | 352,921 |      99 |          92 |              6.57 |          477 |            7504 |              120383 |             128.48 |          0.9 |      0 |  1.00 |

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs

benaadams · 2020-04-28T20:09:59Z

Tried resolving conflicts via GitHub UI, lets see how it goes :)

benaadams · 2020-04-28T23:10:18Z

Looked like it worked :)

benaadams · 2020-04-28T23:10:59Z

@aspnet-hello benchmark

pr-benchmarks · 2020-04-28T23:12:19Z

Starting 'Default' pipelined plaintext benchmark with session ID '684b66427d404f2097f57425616ea12e'. This could take up to 30 minutes...

pr-benchmarks · 2020-04-28T23:16:39Z

Baseline

Starting baseline run on '5fc067266f739695291acc935ae0dd6a4a7a8e78'...
RequestsPerSecond:           342,290
Max CPU (%):                 99
WorkingSet (MB):             89
Avg. Latency (ms):           6.79
Startup (ms):                562
First Request (ms):          170.16
Latency (ms):                0.47
Total Requests:              5,168,158
Duration: (ms)               15,100
Socket Errors:               0
Bad Responses:               0
Build Time (ms):             25,011
Published Size (KB):         120,463
SDK:                         5.0.100-preview.2.20120.3
Runtime:                     5.0.0-preview.5.20225.8
ASP.NET Core:                5.0.0-preview.5.20223.13

PR

Starting PR run on '78281ddd973b86af94788265c934e4de06558d1f'...
| Description |     RPS | CPU (%) | Memory (MB) | Avg. Latency (ms) | Startup (ms) | Build Time (ms) | Published Size (KB) | First Request (ms) | Latency (ms) | Errors | Ratio |
| ----------- | ------- | ------- | ----------- | ----------------- | ------------ | --------------- | ------------------- | ------------------ | ------------ | ------ | ----- |
|      Before | 342,290 |      99 |          89 |              6.79 |          562 |           25011 |              120463 |             170.16 |         0.47 |      0 |  1.00 |
|       After | 353,649 |      99 |          88 |              6.49 |          489 |            7502 |              120463 |             132.18 |         1.02 |      0 |  1.03 |

halter73 · 2020-04-29T23:25:46Z

Thanks again!

ghost added the area-servers label Apr 20, 2020

analogrelay added this to the 5.0.0-preview5 milestone Apr 20, 2020

benaadams force-pushed the ParseConnection-Test branch from 5921591 to d5166ab Compare April 23, 2020 04:01

benaadams changed the title ~~Test~~ Make connection options parsing "safe" Apr 23, 2020

benaadams mentioned this pull request Apr 23, 2020

[Jit] Redundant comparisons are not eliminated dotnet/runtime#35348

Closed

benaadams marked this pull request as ready for review April 23, 2020 15:57

benaadams requested review from analogrelay, halter73, jkotalik and Tratcher as code owners April 23, 2020 15:57

gfoidl reviewed Apr 23, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

khellang reviewed Apr 24, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

benaadams commented Apr 24, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

benaadams force-pushed the ParseConnection-Test branch from c0ddcd3 to 74657de Compare April 24, 2020 23:38

gfoidl reviewed Apr 25, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

gfoidl mentioned this pull request Apr 25, 2020

Make GetFinalTransferCoding "safe" #21202

Merged

benaadams force-pushed the ParseConnection-Test branch from ad930e8 to 0632ea1 Compare April 25, 2020 14:12

Make connection options parsing "safe"

a63aa66

benaadams force-pushed the ParseConnection-Test branch from 0632ea1 to a63aa66 Compare April 25, 2020 19:25

jaredpar mentioned this pull request Apr 27, 2020

OSX machines are de-provisioned during CI / PR runs leading to failures dotnet/runtime#34472

Closed

halter73 reviewed Apr 28, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

halter73 reviewed Apr 28, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

halter73 approved these changes Apr 28, 2020

View reviewed changes

Feedback

336a43e

halter73 reviewed Apr 28, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

halter73 reviewed Apr 28, 2020

View reviewed changes

src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs Outdated Show resolved Hide resolved

halter73 and others added 2 commits April 28, 2020 12:57

Apply suggestions from code review

cd3dd77

Merge branch 'master' into ParseConnection-Test

78281dd

halter73 merged commit 3af92e2 into dotnet:master Apr 29, 2020

benaadams deleted the ParseConnection-Test branch May 27, 2020 06:47

amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make connection options parsing "safe" #21004

Make connection options parsing "safe" #21004

benaadams commented Apr 20, 2020 •

edited

Loading

benaadams commented Apr 20, 2020

pr-benchmarks bot commented Apr 20, 2020

pr-benchmarks bot commented Apr 20, 2020

benaadams commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

benaadams commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

benaadams commented Apr 23, 2020

benaadams commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

benaadams commented Apr 24, 2020

pr-benchmarks bot commented Apr 24, 2020

pr-benchmarks bot commented Apr 24, 2020

benaadams commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

benaadams commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

benaadams commented Apr 28, 2020

benaadams commented Apr 28, 2020

benaadams commented Apr 28, 2020

pr-benchmarks bot commented Apr 28, 2020

pr-benchmarks bot commented Apr 28, 2020

halter73 commented Apr 29, 2020

Make connection options parsing "safe" #21004

Make connection options parsing "safe" #21004

Conversation

benaadams commented Apr 20, 2020 • edited Loading

benaadams commented Apr 20, 2020

pr-benchmarks bot commented Apr 20, 2020

pr-benchmarks bot commented Apr 20, 2020

Baseline

PR

benaadams commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

Baseline

PR

benaadams commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

Baseline

PR

benaadams commented Apr 23, 2020

benaadams commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

pr-benchmarks bot commented Apr 23, 2020

Baseline

PR

benaadams commented Apr 24, 2020

pr-benchmarks bot commented Apr 24, 2020

pr-benchmarks bot commented Apr 24, 2020

Baseline

PR

benaadams commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

Baseline

PR

benaadams commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

pr-benchmarks bot commented Apr 25, 2020

Baseline

PR

benaadams commented Apr 28, 2020

benaadams commented Apr 28, 2020

benaadams commented Apr 28, 2020

pr-benchmarks bot commented Apr 28, 2020

pr-benchmarks bot commented Apr 28, 2020

Baseline

PR

halter73 commented Apr 29, 2020

benaadams commented Apr 20, 2020 •

edited

Loading