-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypasses deserialization of return value when 'InvokeVoidAsync' is used. #22056
Closed
StevenRasmussen
wants to merge
8
commits into
dotnet:master
from
StevenRasmussen:invokeVoidAsync-fix
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
defef94
Bypasses deserialization of return value when 'InvokeVoidAsync' is used.
ca19908
Set TaskCompletionSource result to 'null' for instances where no valu…
711851c
Merge branch 'master' into invokeVoidAsync-fix
StevenRasmussen 0ebab51
Remove 'InvokeVoidAsync' method from JSRuntime and intstead call 'Inv…
StevenRasmussen 68c41ab
Update JsInProcessRuntimeExtensions to use VoidReturn for 'InvokeVoid…
StevenRasmussen 2691bf1
Add new 'treatReturnAsVoid' parameter to 'invokeJSFromDotNet' method.
StevenRasmussen 8f8d165
Added 'treatReturnAsVoid' to InvokeJS method.
StevenRasmussen e7e0cdb
Updated methods to pass allong new 'treatReturnAsVoid' parameter.
StevenRasmussen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
using System.Threading.Tasks; | ||
|
||
namespace Microsoft.JSInterop | ||
{ | ||
/// <summary> | ||
/// Used as a type for the <see cref="TaskCompletionSource{TResult}"/> that represents nothing should be returned. | ||
/// </summary> | ||
internal sealed class VoidReturn | ||
{ | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like from the comments in the
InvokeJSMarshalled
method that there's some magic that happens here that passes this newboolean
arg to JS? Seems like it should just work? Or do we need to be passing thetreatReturnAsVoid
parameter as part of theargsJson
and somehow extracting it on the JS side?