Sync shared code from runtime #22619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@Tratcher, as I was updating all of the runtime code for the new API, I forgot about the mirroring here. What's the best option for you? Should I revert the changes to this file in runtime and close this? Or just wait for this PR until aspnetcore picks up a newer runtime that has the new API? |
|
No worries. I'll check tomorrow how long we expect it to take to get a runtime build. If it's just a few days then I might close the PRs until we get one that passes. At least it's doing its job about nagging us 😁. |
Tratcher
added
the
blocked
Tratcher
approved these changes
Jun 8, 2020
|
Hello @Tratcher! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
Cool, thanks for shepherding it through. |
dougbu
removed
the
blocked
amcasey
added
area-networking
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to sync shared code changes from runtime. Fixes #18943