Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test runner to 2.4.3 #24685

Merged
merged 8 commits into from
Aug 10, 2020
Merged

Update test runner to 2.4.3 #24685

merged 8 commits into from
Aug 10, 2020

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Aug 7, 2020

Using rc1 SDK requires an update to the test runner. In the absence of this change
dotnet test silently fails. This means none of our helix tests are currently executing.

@pranavkm
Update test runner to 2.4.3
a240ccf 
Using rc1 SDK requires an update to the test runner. In the absence of this change
dotnet test silently fails. This means none of our helix tests are currently executing.
@pranavkm pranavkm requested a review from dougbu as a code owner August 7, 2020 20:23
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 7, 2020
@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 7, 2020

PR to fix this in Arcade: dotnet/arcade#5908.

@ghost
Copy link

ghost commented Aug 7, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 52 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@pranavkm pranavkm added this to the 5.0.0-rc1 milestone Aug 7, 2020
@pranavkm pranavkm force-pushed the prkrishn/run-tests branch from 922d5d6 to 72c727c Compare August 8, 2020 00:16
@pranavkm pranavkm mentioned this pull request Aug 8, 2020
Closed
@pranavkm pranavkm force-pushed the prkrishn/run-tests branch from 72c727c to bf5feaf Compare August 8, 2020 00:55
dougbu
dougbu approved these changes Aug 8, 2020
View reviewed changes
eng/Dependencies.props Outdated Show resolved Hide resolved
eng/SharedFramework.External.props
@@ -40,7 +40,6 @@
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Options.DataAnnotations" Version="$(MicrosoftExtensionsOptionsDataAnnotationsPackageVersion)" />
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Options" Version="$(MicrosoftExtensionsOptionsPackageVersion)" />
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Primitives" Version="$(MicrosoftExtensionsPrimitivesPackageVersion)" />
<ExternalAspNetCoreAppReference Include="System.IO.Pipelines" Version="$(SystemIOPipelinesPackageVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal and the test fixes should close #24392 Thanx❕

src/Servers/Connections.Abstractions/src/Microsoft.AspNetCore.Connections.Abstractions.csproj
@@ -13,7 +13,6 @@

<ItemGroup>
<Reference Include="Microsoft.AspNetCore.Http.Features" />
<Reference Include="System.IO.Pipelines" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. This was brought in transitively through Microsoft.AspNetCore.Http.Features since forever

dougbu
dougbu reviewed Aug 8, 2020
View reviewed changes
eng/Versions.props
@@ -279,6 +279,7 @@
<XunitAssertPackageVersion>$(XunitVersion)</XunitAssertPackageVersion>
<XunitExtensibilityCorePackageVersion>$(XunitVersion)</XunitExtensibilityCorePackageVersion>
<XunitExtensibilityExecutionPackageVersion>$(XunitVersion)</XunitExtensibilityExecutionPackageVersion>
<XUnitRunnerVisualStudioVersion>2.4.3</XUnitRunnerVisualStudioVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teensy nit: Should we have a comment reminding us to remove this line once we pick up Arcade bits containing the dotnet/arcade#5908 fix❔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #24750

@pranavkm pranavkm force-pushed the prkrishn/run-tests branch from bf5feaf to 9996c8a Compare August 8, 2020 20:46
@pranavkm pranavkm force-pushed the prkrishn/run-tests branch from 9996c8a to 7430d9f Compare August 8, 2020 22:35
@jkotalik
Copy link
Contributor

Couple of missed tests, should be green now.

@jkotalik jkotalik merged commit 56be06b into master Aug 10, 2020
@jkotalik jkotalik deleted the prkrishn/run-tests branch August 10, 2020 19:32
@dougbu dougbu mentioned this pull request Aug 15, 2020
Closed
@pranavkm pranavkm mentioned this pull request Dec 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 halter73 approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.
6 participants
@pranavkm @jkotalik @halter73 @dougbu @BrennanConroy @wtgodbe