Quick infrastructure fix-ups #25545

dougbu · 2020-09-02T21:16:43Z

pin Microsoft.Net.Compilers.Toolset version to isolate us from Arcade
- the version now matches dotnet/runtime
- will move the pin to previous version if anything breaks
double the macOS job max. length in our quarantined PR runs
- have been seeing this timeout too often

- pin Microsoft.Net.Compilers.Toolset version to isolate us from Arcade - the version now matches dotnet/runtime - will move the pin to previous version if anything breaks - double the macOS job max. length in our quarantined PR runs - have been seeing this timeout too often

dougbu · 2020-09-02T21:19:51Z

eng/Version.Details.xml

@@ -329,9 +329,9 @@
      <Uri>https://github.com/dotnet/arcade</Uri>
      <Sha>4be47e467013f8a07a1ed7b6e49e39c8150bde54</Sha>
    </Dependency>
-    <Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.8.0-2.20407.3">
+    <Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.8.0-2.20403.2" Pinned="true">


@pranavkm the previous version came in through adea663 aka #24738. Do you know if we took a dependency on anything changed after 3.8.0-2.20403.2❔ It's a small window compared to the upgrade in that PR but I'm confirming❕

Why pin this?

@TanayParikh this won't protect us from downgrades in the 'master' branch 'til it's merged forward and also won't impact the aspnetcore ➡️ aspnetcore-tooling dependency updates 'til then. Suggest we trigger our Roslyn subscription to get back to being ahead of Arcade in this version on our 'master' branch. Do you know how to do that❔ If not, ping me in Teams.

Why pin this?

This is for safety. We've seen runtime changes break roslyn and then roslyn break runtime and extensions too late in the game. Had an offline conversation about this w/ @Anipik @ericstj @jaredpar @mmitche @safern and we landed on this version. (Might move forward slightly later in RC2 but that'll be deliberate and coordinated.)

/fyi all. This version has been discussed in a few different places, the latest being dotnet/roslyn#46575. In RC2, runtime, aspnetcore, and extensions will use 3.8.0-2.20403.2. (aspnetcore-tooling doesn't have release/5.0* branches.)

The plan is different in our master branches. At least arcade, aspnetcore and aspnetcore-tooling will follow the 'VS 16.8' channel to get newer Microsoft.Net.Compilers.Toolset versions. We will likely move to use the 'VS Master' channel later in 6.0.

dougbu · 2020-09-02T21:20:12Z

.azure/pipelines/quarantined-pr.yml

@@ -86,7 +86,7 @@ jobs:
    jobName: MacOS_Quarantined_Test
    jobDisplayName: "Tests: macOS 10.14"
    agentOs: macOS
-    timeoutInMinutes: 60
+    timeoutInMinutes: 120


/fyi @JunTaoLuo @TanayParikh

Ah, crap, I forgot to fix this in the regular job. Will go do that now

That job hasn't been timing out has it i.e. weren't the timeouts specific to the quarantined pipeline❔

And, oops, forgot you were doing this part

Not sure, I thought you meant it was both - I can close #25546 if it's just this one

Hmm, ci.yml doesn't specify timeouts (except for the Helix job) which means its macOS test job gets the default-build.yml default of 180 minutes. Since that's so close to when https://dev.azure.com/dnceng/public/_build/results?buildId=795980&view=results passed, I'll use 240 minutes there.

Let me clarify, the aspnetcore-ci run completed after 90 minutes so it still passed without timing out. I think a default timeout of 180 minutes is still fine. I just wanted to mention that build because 90 minutes is more than 3x the usual time of about 25 mins. It's slow, but I don't think we need to adjust our timeout for it.

I pushed a change to err on the safe side. The extra half hour timeout is less likely to cause problems elsewhere than having to retry a 1.5 hour job.

(Note I didn't double the timeout there😃)

I haven't paid too much attention to it after my ops rotation so my sample size is limited, but I've seen slowness in macos builds both on aspnetcore-ci and aspnetcore-quarantined-pr.

About the same for me as well. Seen occasional slowness for macos specifically.

dougbu · 2020-09-02T21:21:27Z

@Pilchie 🆗 for RC2❔

@dougbu

- Pin Microsoft.Net.Compilers.Toolset version to isolate us from Arcade - The version now matches dotnet/runtime - Will move the pin to previous version if anything breaks In conjunction with: dotnet/aspnetcore#25545 cc/ @dougbu

Pilchie · 2020-09-02T22:05:47Z

Yes, tell mode okay with me when CI is happy.

ghost · 2020-09-03T00:27:55Z

Hello @dougbu!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost · 2020-09-03T00:28:14Z

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

ghost · 2020-09-03T02:22:14Z

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

dougbu requested review from pranavkm and a team September 2, 2020 21:16

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 2, 2020

dougbu commented Sep 2, 2020

View reviewed changes

TanayParikh mentioned this pull request Sep 2, 2020

Quick infrastructure fix-ups dotnet/razor#2464

Closed

wtgodbe mentioned this pull request Sep 2, 2020

Double timeout for MacOS test job #25546

Closed

wtgodbe approved these changes Sep 2, 2020

View reviewed changes

safern approved these changes Sep 2, 2020

View reviewed changes

safern mentioned this pull request Sep 2, 2020

NRE in GetExplicitInterfaceImplementations when building dotnet/runtime dotnet/roslyn#46575

Closed

Increase macOS test job timeout in ci.yml too

f83ed12

dougbu added the auto-merge label Sep 3, 2020

dougbu merged commit 3ef9fbe into release/5.0-rc2 Sep 3, 2020

dougbu deleted the dougbu/timeouts.n.versions branch September 3, 2020 02:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quick infrastructure fix-ups #25545

Quick infrastructure fix-ups #25545

dougbu commented Sep 2, 2020

dougbu Sep 2, 2020

wtgodbe Sep 2, 2020

dougbu Sep 2, 2020

dougbu Sep 2, 2020

dougbu Sep 3, 2020

dougbu Sep 2, 2020

wtgodbe Sep 2, 2020

dougbu Sep 2, 2020

dougbu Sep 2, 2020

wtgodbe Sep 2, 2020

dougbu Sep 3, 2020

JunTaoLuo Sep 3, 2020

dougbu Sep 3, 2020

dougbu Sep 3, 2020

TanayParikh Sep 3, 2020

dougbu commented Sep 2, 2020

Pilchie commented Sep 2, 2020

ghost commented Sep 3, 2020

ghost commented Sep 3, 2020

ghost commented Sep 3, 2020

Quick infrastructure fix-ups #25545

Quick infrastructure fix-ups #25545

Conversation

dougbu commented Sep 2, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dougbu commented Sep 2, 2020

Pilchie commented Sep 2, 2020

ghost commented Sep 3, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Sep 3, 2020

ghost commented Sep 3, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.