Guard more logging calls in CertificateManager #29515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #27956 I was surprised to see CertificageManagerEventSource still showing up in traces when events were disabled, until I realized that the logging methods themselves were doing formatting work, generally via string interpolation, e.g.
This adds guards to the logging methods themselves if they do anything other than pass along state to the underlying WriteEvent.
cc: @brianrob, @davidfowl