-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/2.1] React to deletion of DockerHub image #34315
Conversation
dougbu
commented
Jul 13, 2021
- had been deprecated for a while
- had been deprecated for a while
If we need this, will be a |
- mainly important in SignalR project nit: Accept minor / patch updates `npm install` brought in
Selenium driver was out-of-date in src\SignalR\clients\ts\webdriver-tap-runner\package.json. I fixed that up in added commit. @BrennanConroy Do we need either update in release/2.1❔ On the other hand, any concerns about the upgrades in the package-lock.json file for that project❔ |
Test code, update looks fine. I assume the audit issues were for the test project? |
I only ran |
The /signalr and /signalr-protocol-msgpack folders are non-test code |
Are you asking me to run |
Don't do anything else here, we're removing/not-shipping the signalr npm bits for 2.1 after August 21st this year. |
@vseanreesermsft @wtgodbe we're open for 2.1.x business i.e. I can merge this, correct❔ |