Update Grpc.Core.Api to 2.45.0 and support write cancellation #41525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
captainsafia,
a team,
dougbu and
wtgodbe
as code owners
BrennanConroy
approved these changes
May 6, 2022
src/Grpc/Interop/test/testassets/InteropWebsite/TestServiceImpl.cs
Outdated
Show resolved
Hide resolved
| @@ -44,6 +44,6 @@ protected override async Task HandleCallAsyncCore(HttpContext httpContext, JsonT | |||
|
|
|||
| serverCallContext.EnsureResponseHeaders(); | |||
|
|
|||
| await JsonRequestHelpers.SendMessage(serverCallContext, SerializerOptions, response); | |||
| await JsonRequestHelpers.SendMessage(serverCallContext, SerializerOptions, response, CancellationToken.None); | |||
There was a problem hiding this comment.
httpContext.RequestAborted?
There was a problem hiding this comment.
All the async operations are on the HttpContext and friends. That cancellation token is implicitly used.
JamesNK
changed the title
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates gRPC to 2.45.0, removes nullable workarounds and adds support for WriteAsync cancellation.
Addresses grpc/grpc-dotnet#1583