Add more info to UnrecognizedMediaType #43100
Conversation
ghost
added
the
| @@ -29,6 +29,9 @@ internal static partial class HttpLoggingExtensions | |||
| [LoggerMessage(5, LogLevel.Debug, "Decode failure while converting body.", EventName = "DecodeFailure")] | |||
| public static partial void DecodeFailure(this ILogger logger, Exception ex); | |||
|
|
|||
| [LoggerMessage(6, LogLevel.Debug, "Unrecognized Content-Type for body.", EventName = "UnrecognizedMediaType")] | |||
| public static partial void UnrecognizedMediaType(this ILogger logger); | |||
| [LoggerMessage(6, LogLevel.Debug, "Unrecognized Content-Type for request body.", EventName = "RequestUnrecognizedMediaType")] | |||
There was a problem hiding this comment.
Let's keep the same id for both logs to avoid any possible breakage no matter how unlikely. We should be able to parameterize just the request/response part of the message.
I was going to suggest including what the unrecognized content-type was exactly. It seems useful for debugging, but then I realize most people logging the body are probably logging the header separately anyway.
There was a problem hiding this comment.
I was going to suggest including what the unrecognized content-type was exactly.
Should there be a different log when there isn't a media type header?
There was a problem hiding this comment.
Is that a common scenario?
There was a problem hiding this comment.
Probably? Isn't that what the original issue was sort of about?
There was a problem hiding this comment.
Agreed. An "Unrecognized Content-Type" log when there isn't a "Content-Type" to begin with is super confusing. I would not log anything at all in that case.
There was a problem hiding this comment.
Added a new log message & a test
|
Is there an issue or other feedback about this? |
|
amcasey
added
area-middleware
This only ever gets fired for the request body, not the response body.