Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer TypeConverter over TryParse #46577

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Prefer TypeConverter over TryParse #46577

merged 3 commits into from
Feb 15, 2023

Conversation

brunolins16
Copy link
Member

Fix #46384

@brunolins16 brunolins16 requested review from halter73 and a team February 11, 2023 00:41
@brunolins16 brunolins16 added the area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Feb 11, 2023
@brunolins16
Copy link
Member Author

@dotnet/minimal-apis could you please review? 🙏

captainsafia
captainsafia approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I left some non-blocking questions inline.

src/Mvc/Mvc.Core/src/ModelBinding/Binders/SimpleTypeModelBinderProvider.cs Show resolved Hide resolved
src/Mvc/test/Mvc.IntegrationTests/SimpleTypeModelBinderIntegrationTest.cs Show resolved Hide resolved
@brunolins16 brunolins16 enabled auto-merge (squash) February 15, 2023 19:04
@brunolins16
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/4187264402

@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Merged
10 tasks
@brunolins16 brunolins16 merged commit 63a0251 into dotnet:main Feb 15, 2023
@ghost ghost added this to the 8.0-preview2 milestone Feb 15, 2023
@brunolins16 brunolins16 deleted the brunolins16/issues/mvc/46384 branch February 15, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Milestone
8.0-preview2
Development

Successfully merging this pull request may close these issues.

DateOnly custom TypeConverter is ignored when using FromQuery
2 participants
@brunolins16 @captainsafia