Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct case in ILCompiler package name #49555

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

lewing
Copy link
Member

@lewing lewing commented Jul 20, 2023

There was a regression in nuget.client that revealed this, the regression has been resolved in NuGet/NuGet.Client#5321 but this still bothered me

(the fix hasn't flowed into sdk yet either)

@lewing lewing requested review from a team and wtgodbe as code owners July 20, 2023 22:30
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 20, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 20, 2023
@ghost
Copy link

ghost commented Jul 20, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@lewing lewing requested a review from sbomer July 20, 2023 22:31
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note it's also being fixed in #49470 - but LGTM.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lewing!

@eerhardt eerhardt enabled auto-merge (squash) July 20, 2023 23:04
@eerhardt eerhardt merged commit d187022 into dotnet:main Jul 20, 2023
@ghost ghost added this to the 8.0-rc1 milestone Jul 20, 2023
@lewing lewing deleted the ilc-name branch July 20, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants