Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to run E2E tests on WebAssembly multithreaded runtime #54351

Merged

Conversation

SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Mar 4, 2024

Fixes #53435

Provides an easy way to have all the E2E tests run on the WebAssembly multithreaded runtime by setting a single MSBuild property in src/Components/test/testassets/Directory.Build.props.

  <PropertyGroup>
    <!--
      This controls whether the WebAssembly E2E tests run with the multithreaded runtime or not.
      It also implicitly sets an assembly metadata attribute so the test servers will serve the COOP
      headers if and only if this flag is set. Note that until https://github.com/dotnet/runtime/issues/98502
      is fixed, you will have to delete artifacts\obj directories after changing this flag.
    -->
    <!--<WasmEnableThreads>true</WasmEnableThreads>-->
  </PropertyGroup>

It's commented out because we don't actually want to enable this by default, because:

  1. This is not the common case
  2. Currently, many of the E2E tests will fail until we implement Make Blazor WebAssembly work on multithreaded runtime #54365

The purpose of this PR is to simplify collaboration around implementing proper support for WebAssembly multithreading.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 4, 2024
The point of this PR is just to make it easy for us to enable this locally when we want
@SteveSandersonMS SteveSandersonMS marked this pull request as ready for review March 11, 2024 15:25
@SteveSandersonMS SteveSandersonMS requested a review from a team as a code owner March 11, 2024 15:25
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@javiercn
Copy link
Member

@SteveSandersonMS Do we want to add an extra CI config to run this leg too?

@SteveSandersonMS
Copy link
Member Author

SteveSandersonMS commented Mar 11, 2024

Do we want to add an extra CI config to run this leg too?

I'd say not until the tests are at least nearly all passing. Right now it would run for hours probably because so many fail, and failed tests take a long time because of all the retries. So it would harm the overall build times for everyone.

@SteveSandersonMS SteveSandersonMS merged commit 7c60951 into main Mar 11, 2024
26 checks passed
@SteveSandersonMS SteveSandersonMS deleted the stevesa/ability-to-run-e2e-tests-with-multithreading branch March 11, 2024 15:42
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview3 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blazor] Way to run the E2E tests against the multithreaded runtime
2 participants