Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partitioned to cookie for SignalR browser testing #57997

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

BrennanConroy
Copy link
Member

Looks like Chromium (not chrome) headless now requires 'partitioned' on the cookie when using Secure and Same-Site=None

Looks like Chromium (not chrome) headless now requires 'partitioned' on the cookie when using `Secure` and `Same-Site=None`
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-signalr Includes: SignalR clients and servers label Sep 20, 2024
src/SignalR/clients/ts/FunctionalTests/Startup.cs Outdated Show resolved Hide resolved
src/SignalR/clients/ts/FunctionalTests/Startup.cs Outdated Show resolved Hide resolved
Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
@halter73
Copy link
Member

You got me thinking Chrome had actually started blocking third-party cookies like they've been talking about and then read the description 😄

Looks like Chromium (not chrome)

@BrennanConroy
Copy link
Member Author

You got me thinking Chrome had actually started blocking third-party cookies like they've been talking about and then read the description 😄

Looks like Chromium (not chrome)

Soon™️

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2024

Merging before I log off for the weekend as the Helix job is unaffected by this change

@wtgodbe wtgodbe merged commit b77c79e into release/9.0-rc2 Sep 20, 2024
23 of 25 checks passed
@wtgodbe wtgodbe deleted the BrennanConroy-patch-2 branch September 20, 2024 23:43
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc2 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants