Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source-build team references #58324

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Oct 9, 2024

Update source-build team references

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

The source-build-internal team is being deprecated. All references to it were updated.

Related to dotnet/source-build#4645

@MichaelSimons MichaelSimons requested review from a team and wtgodbe as code owners October 9, 2024 18:45
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 9, 2024
@MichaelSimons MichaelSimons requested review from a team and removed request for a team October 9, 2024 18:45
@@ -16,7 +16,7 @@
/eng/common/ @dotnet-maestro-bot
/eng/Versions.props @dotnet-maestro-bot @dotnet/aspnet-build @wtgodbe
/eng/Version.Details.xml @dotnet-maestro-bot @dotnet/aspnet-build @wtgodbe
/eng/SourceBuild* @dotnet/source-build-internal
/eng/SourceBuild* @dotnet/source-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as dotnet/aspire#6210 (comment), do we have write access?

@MichaelSimons
Copy link
Member Author

@wtgodbe - Can you grant @dotnet/source-build write access and remove @dotnet/source-build-internal?

@wtgodbe
Copy link
Member

wtgodbe commented Oct 10, 2024

@wtgodbe - Can you grant @dotnet/source-build write access and remove @dotnet/source-build-internal?

Done

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@MichaelSimons MichaelSimons merged commit 54c0cc8 into dotnet:main Oct 10, 2024
27 checks passed
@MichaelSimons MichaelSimons deleted the rename-sb branch October 10, 2024 17:07
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants