Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcadeBuildFromSource -> DotNetBuildSourceOnly #58423

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Oct 14, 2024

Change from old control to new control. I think the intention here was that we should never install puppeteer in outer or inner source-only scenarios.

@mmitche mmitche requested review from wtgodbe and a team as code owners October 14, 2024 18:44
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 14, 2024
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the submodule change?

@mmitche mmitche enabled auto-merge (squash) October 14, 2024 18:51
@mmitche mmitche merged commit d316ac6 into dotnet:main Oct 14, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants