Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HtmlAttributePropertyHelper to correctly follow the MetadataUpdateHandlerAttribute contract #58558

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

MackinnonBuck
Copy link
Member

Fixes an issue where HtmlAttributePropertyHelper did not correctly follow the MetadataUpdateHandlerAttribute contract, causing hot reload to fail.

Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3202

@MackinnonBuck MackinnonBuck added feature-hot-reload This issue is related to the Hot Reload feaature area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages labels Oct 21, 2024
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner October 21, 2024 22:54
@MackinnonBuck MackinnonBuck requested a review from a team October 21, 2024 22:55
@MackinnonBuck MackinnonBuck changed the title Updated HtmlAttributePropertyHelper to correctly follow the MetadataUpdateHandlerAttribute contract Update HtmlAttributePropertyHelper to correctly follow the MetadataUpdateHandlerAttribute contract Oct 21, 2024
@MackinnonBuck MackinnonBuck merged commit 5f156a2 into main Oct 22, 2024
27 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/fix-htmlattributepropertyhelper branch October 22, 2024 18:50
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages feature-hot-reload This issue is related to the Hot Reload feaature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants