Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set target platform for wixproj and vcxproj correctly #59194

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ViktorHofer
Copy link
Member

wixprojs allow x86, x64 and arm64 (idetical to the TargetArchitecture platform) vcxprojs allow Win32, x64 and ARM64

Identified in dotnet/sdk#45162
Fixes dotnet/source-build#4767

wixprojs allow x86, x64 and arm64 (idetical to the TargetArchitecture platform)
vcxprojs allow Win32, x64 and ARM64
@ViktorHofer ViktorHofer requested review from wtgodbe and a team as code owners November 27, 2024 09:33
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 27, 2024
@ViktorHofer ViktorHofer enabled auto-merge (squash) November 27, 2024 13:31
@ViktorHofer ViktorHofer merged commit 9953c27 into main Nov 27, 2024
27 checks passed
@ViktorHofer ViktorHofer deleted the wixprojsvcxprojtargetplatform branch November 27, 2024 13:34
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMR win-x86 builds are broken in aspnetcore
2 participants