Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Include .webmanifest in Offline Cache for Default PWA Service Worker #59231

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix: Include .webmanifest in Offline Cache for Default PWA Service Worker #59231

merged 2 commits into from
Dec 12, 2024

Conversation

shethaadit
Copy link
Contributor

Fix: Include .webmanifest in Offline Cache for Default PWA Service Worker

  • [Y] You've read the Contributor Guide and Code of Conduct.
  • [Y] You've included unit or integration tests for your change, where applicable.
  • [Y] You've included inline docs for your change, where applicable.
  • [Y] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

This PR addresses a bug where the manifest.webmanifest file is not included in the offline cache after the file extension change implemented in #43756 .

Changes Made
Updated the offlineAssetsInclude configuration in service-worker.published.js to include the .webmanifest extension:

Expected Behavior
The default PWA service worker implementation now correctly caches the manifest.webmanifest file.

Fixes #54953

@shethaadit shethaadit requested a review from a team as a code owner November 30, 2024 11:28
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Nov 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 30, 2024
@shethaadit
Copy link
Contributor Author

Hi @mkArtakMSFT/team, could you please help reviewing/approving the PR? :)

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 11, 2024
@MackinnonBuck
Copy link
Member

Thanks, @shethaadit!

@MackinnonBuck MackinnonBuck merged commit 9ab6570 into dotnet:main Dec 12, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees

@MackinnonBuck MackinnonBuck

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.

Cache manifest.webmanifest in PWA
2 participants
@shethaadit @MackinnonBuck