FieldRVA alignment mono/cecil tree #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In support of dotnet/runtime#60948 the linker (an assembly rewriter) will need to be able to preserve the alignment of RVA based fields which are to be used to create the data for `CreateSpan<T>` records This is implemented by adding a concept that RVA fields detect their required alignment by examining the PackingSize of the type of the field (if the field type is defined locally in the module)
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
|
@vitek-karas Can you approve/merge this PR? |
vitek-karas
approved these changes
Jan 18, 2022
|
I can't merge - maybe @agocke or @marek-safar can? |
|
No luck on my side |
|
It seems the change is about to get in upstream. Unless there is some delay I'd prefer to pull from upstream instead of cherry-picking changes to make the synchronization easier in the future (I'm happy to do that it's just one git command). |
|
@marek-safar I agree. Upstream now has the fix in it. It looks like it is time to take a pull from upstream though. Could do that? Thanks. |
|
@davidwrighton done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of PR jbevain#817 to mono/cecil tree
In support of dotnet/runtime#60948 the linker (an assembly rewriter) will need to be able to preserve the alignment of RVA based fields which are to be used to create the data for CreateSpan records
This is implemented by adding a concept that RVA fields detect their required alignment by examining the PackingSize of the type of the field (if the field type is defined locally in the module)
This has been approved in the jbevain tree, but we need this sooner rather than later, so I've made a direct PR here as well.