Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Use msbuild /restore instead of a separate process #7896

Merged
merged 3 commits into from
Oct 27, 2017

Commits on Oct 24, 2017

  1. Remove unnecessary handling of verbosity in RestoreCommand

    We were taking care to set the console verbosity to minimal, but
    only when no verbosity argument is passed. However, the default
    verbosity for all CLI msbuild commands is already minimal and so
    we can just get out of the way.
    nguerrera committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    20b0b82 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. Configuration menu
    Copy the full SHA
    8fead78 View commit details
    Browse the repository at this point in the history
  2. Use msbuild /restore instead of separate invocations where possible

    It is not currently possible when there is a -f|--framework argument because
    we cannot force a TargetFramework global property on to the restore evaluation.
    Doing so completely breaks restore by applying the TargetFramework to all
    projects transitively. The correct behavior is to restore for all frameworks,
    then build/publish/etc for the given target framework. Achieving that still
    requires two distinct msbuild invocations.
    
    This also changes the verbosity of implicit restore from quiet to that
    of the subsequent command (default=minimal). Similar to global properties,
    we cannot specify a distinct console verbosity for the /restore portion of
    the overall execution. For consistency, we apply the same verbosity change
    to the case where we still use two separate msbuild invocations.
    
    This also fixes an issue where the separate restore invocation's msbuild log
    would be overwritten by the subsequent command execution. However, this remains
    unfixed in the case where we still use two separate msbuild invocations.
    nguerrera committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    35b7ad2 View commit details
    Browse the repository at this point in the history