Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set russian language #1381

Closed
wants to merge 1 commit into from
Closed

Set russian language #1381

wants to merge 1 commit into from

Conversation

akprof2000
Copy link

Write translate file for Russian language

Write translate file for Russian language
@dnfadmin
Copy link

dnfadmin commented Aug 19, 2021

CLA assistant check
All CLA requirements met.

@adamsitnik adamsitnik mentioned this pull request Feb 2, 2023
4 tasks
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM, thank you for your contribution @akprof2000

There is a merge conflict and the source repo has been deleted. I'll try to find a workaround to it to get it merged.

<note />
</trans-unit>
<trans-unit id="CommandNoArgumentProvided">
<source>No argument was provided for Command '{0}'.</source>
<target state="new">No argument was provided for Command '{0}'.</target>
<target state="new">Нет аргументов для команды '{0}'.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: according to google translate it means "No argument for command". We are missing the "was provided"

<note />
</trans-unit>
<trans-unit id="ExceptionHandlerHeader">
<source>Unhandled exception: </source>
<target state="new">Unhandled exception: </target>
<target state="new">Необработанная ошибка: </target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: According to google translate ошибка means "error". Would "исключение" be a better name for exception?

<note />
</trans-unit>
<trans-unit id="HelpUsageOptionsTitle">
<source>[options]</source>
<target state="new">[options]</target>
<target state="new">[опция]</target>
Copy link
Member

@adamsitnik adamsitnik Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need plural (options)

Suggested change
<target state="new">[опция]</target>
<target state="new">[oпции]</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to capital О?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KalleOlaviNiemitalo great catch!

@adamsitnik
Copy link
Member

I am sorry, I've tried solving the merge conflicts but it seems impossible because of the fact the the repo was removed.

@adamsitnik adamsitnik closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants