Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename members to GetValue #1787

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Rename members to GetValue #1787

merged 1 commit into from
Oct 31, 2022

Conversation

Keboo
Copy link
Member

@Keboo Keboo commented Jul 1, 2022

Added GetValue methods to InvocationContext
Renamed GetValueForOption and GetValueForArgument on ParseResult and SymbolResult classes

Fixes #1785

Copy link
Contributor

@jonsequitur jonsequitur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated for breaking change in PR

@Keboo Keboo force-pushed the fix1785 branch 3 times, most recently from 152c397 to a665e15 Compare July 12, 2022 19:33
Added GetValue methods to InvocationContext
Renamed GetValueForOption and GetValueForArgument on ParseResult and SymbolResult classes
Fixing compilation tests
@jonsequitur jonsequitur merged commit b8ddb00 into dotnet:main Oct 31, 2022
@jonsequitur
Copy link
Contributor

Thanks, @Keboo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename GetValueForOption and GetValueForArgument to GetValue and add these methods to InvocationContext
2 participants