Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[release/3.0] Switch to Arcade yaml stage-based publishing with custom steps #7735

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

dagood
Copy link
Member

@dagood dagood commented Aug 15, 2019

Ports #7725 to release/3.0 for #7118. For 3.0 serviceability.

Ports #7754 to temporarily work around https://github.com/dotnet/core-eng/issues/7448.

Ports #7765, a fixup to how -warnAsError:$false is passed.

One cherry-pick conflict: removing <Channel>release/3.0</Channel>. This has been moved to a cross-branch mapping of BAR channels to dotnetcli channels in azure-pipelines.yml. .NET Core 3 Dev is mapped to release/3.0.

The new publish flow is not yet validated in master official builds.

/cc @wtgodbe @mmitche

* Switch to stage-based publishing with custom steps

* Workaround: allow known symbol publisher warnings

Use Arcade-supported symbol publish workaround

* Workaround: run gather drop dry to avoid flakiness

* Use hosted pool for custom publish

(cherry picked from commit 002bc9e)

# Conflicts:
#	eng/Versions.props
@dagood dagood requested a review from MichaelSimons August 15, 2019 18:30
@dagood dagood self-assigned this Aug 15, 2019
@dagood dagood added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 16, 2019
@dagood dagood removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 19, 2019
Symbol publish is failing due to lack of space in the current agent pool. Move to a pool that is working for other jobs. This is temporary because Maestro++ will overwrite it with the next Arcade update.
@dagood
Copy link
Member Author

dagood commented Aug 19, 2019

Build and subscriptions went through in master after adding #7765:

dotnet/extensions#2199
dotnet/ef6#1159
dotnet/cli#12266
dotnet/coreclr#26247

The next Arcade update (#7760) contains the expected fix for https://github.com/dotnet/core-eng/issues/7448, so there won't be a known build break when the temporary workaround is removed.

Ready to merge to 3.0. @MichaelSimons PTAL

@dagood dagood added this to the 3.0 milestone Aug 19, 2019
@dagood dagood merged commit 5b508e8 into dotnet:release/3.0 Aug 19, 2019
@dagood dagood deleted the stages-publishing-3.0 branch August 19, 2019 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants