-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add api diff for preview6 #6417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The System.Threading.Channels.md
part LGTM, but the diff is missing the new System.IO APIs added in #53669
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.Threading.Channels and System.IO LGTM, thank you @Anipik
@@ -0,0 +1,14 @@ | |||
# System.Numerics | |||
|
|||
``` diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numerics changes LGTM. CC. @pgovind
@@ -0,0 +1,21 @@ | |||
# System.Runtime.Intrinsics.X86 | |||
|
|||
``` diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intrinsics LGTM. CC @echesakovMSFT, @pgovind
Do we need to do anything explicit to express these are RequiresPreviewFeatures
?
The attribute is in the ref but isn't relayed here and likely not readily visible in the docs/etc
CC. @terrajobst, @carlossanlop, @jeffhandley ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created dotnet/dotnet-api-docs#6861 for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anipik, can we ensure that a particular attribute is included in the future diffs (namely RequiresPreviewFeature
)?
For System.Threading, the new ones shown look good to me, but the new APIs from dotnet/runtime#53899 may be missing. |
Those will be in Preview 7. |
release-notes/6.0/preview/api-diff/preview6/Asp.Net/6.0-preview6_Microsoft.AspNetCore.Http.md
Show resolved
Hide resolved
This diff appears to be missing the AddEndpointsApiExplorer extension method added here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.Net.* namespaces are good
System.Security.* LGTM. I don't see System.IO.Hashing -- I'm guessing full OOBs don't show up? |
nope. just the ref packs |
|
||
``` diff | ||
namespace System.Text { | ||
+ public ref struct SpanLineEnumerator { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's the EnumerateLines method that creates this?
cc @adamsitnik @carlossanlop @jozkee @eiriktsarpalis @layomia @buyaa-n @joperezr @krwq @kouvel @pgovind @tannergooding @steveharter @tarekgh @dotnet/ncl
@stephentoub @ericstj @danmoseley
cc @pranavkm @Tratcher @Pilchie @davidfowl @dougbu @richlander