-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch-release JSON files #9480
Conversation
We should decide what we want to do w/schemas for these new files. Context: #9431 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm fine with blob or GH links either way. As I'm not using them right now, I'm also fine with them only being added for 8+. Since .NET 6 is EOL soon anyway, I think that should be fine for most anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release-notes/8.0/patch-releases-index.json
.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release-notes/8.0/patch-releases-index.json
}, | ||
{ | ||
"release-version": "9.0.0-preview.1", | ||
"release-date": "2024-02-13", | ||
"security": false, | ||
"release-info-uri": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/9.0/preview/preview1/release.json" | ||
"release-info-uri": "https://raw.githubusercontent.com/dotnet/core/main/release-notes/9.0/preview/preview1/release.json" | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release-notes/8.0/patch-releases-index.json
.patch |
Please stop posting these messages @admin-xspace. |
I generated patch-release files for 8.0+. That was a choice. We can make a different choice.
There are links to blob storage. We can copy the files before merging or we make these GH links (it's just a code change) while we're getting this all figured out. Either works for me.
https://github.com/dotnet/core/pull/9480/files#diff-4792c8566cd38c9a12d0f0d06b0c9fc272aa7c941324a18da65dc9223b05955bR11
Contributes to #9417 and borrows from #9427.
@Falco20019 @leecow