Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch-release JSON files #9480

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Add patch-release JSON files #9480

merged 2 commits into from
Aug 30, 2024

Conversation

richlander
Copy link
Member

@richlander richlander commented Aug 22, 2024

I generated patch-release files for 8.0+. That was a choice. We can make a different choice.

There are links to blob storage. We can copy the files before merging or we make these GH links (it's just a code change) while we're getting this all figured out. Either works for me.

https://github.com/dotnet/core/pull/9480/files#diff-4792c8566cd38c9a12d0f0d06b0c9fc272aa7c941324a18da65dc9223b05955bR11

Contributes to #9417 and borrows from #9427.

@Falco20019 @leecow

@richlander
Copy link
Member Author

We should decide what we want to do w/schemas for these new files.

Context: #9431 (comment)

Copy link
Contributor

@Falco20019 Falco20019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm fine with blob or GH links either way. As I'm not using them right now, I'm also fine with them only being added for 8+. Since .NET 6 is EOL soon anyway, I think that should be fine for most anyway.

@richlander richlander merged commit 2d75c33 into main Aug 30, 2024
3 checks passed
@richlander richlander deleted the patch-release-json branch August 30, 2024 04:11
@richlander
Copy link
Member Author

richlander commented Aug 30, 2024

Please stop posting these messages @admin-xspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants