This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use volatile load to read brick table entries #17717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #17716
stephentoub
reviewed
Apr 21, 2018
| return VolatileLoadWithoutBarrier(&brick_table [index]); | ||
| #else | ||
| return brick_table[index]; | ||
| #endif |
There was a problem hiding this comment.
The special casing of 0 and positive values wasn't necessary?
There was a problem hiding this comment.
The original method was unused before. I have deleted the original method because of it had the buggy pattern, and added a new one with similar name that does what I need.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17716