This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use Modern CMake features instead of CMAKE_CXX_FLAGS #24861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LAGS to Modern CMake isms.
…m Clang and remove CMP0025 policy setting.
|
/azp run coreclr-ci |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
The Linux_musl x64 release test failure is a timeout in the JIT.Methodical.eh test run. |
|
GCC build still works with your branch. |
janvorli
approved these changes
Jun 3, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…24861) * Convert C++ standard settings and warning options from CMAKE_<LANG>_FLAGS to Modern CMake isms. * More $<COMPILE_LANGUAGE> generator expressions instead of CMAKE_CXX_FLAGS. * Use $<COMPILE_LANGUAGE:CXX> for all -fpermissive usage * Fix generator expression that generates multiple flags * Fix invalid use of CMAKE_CXX_FLAGS instead of CMAKE_C_FLAGS. * Treat AppleClang as though it is Clang (match pre-3.0 behavior). * Update our build system to understand that AppleClang is distinct from Clang and remove CMP0025 policy setting. * PR Feedback. Commit migrated from dotnet/coreclr@90dd13e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our minimum CMake version is 3.5.1, use the
CMAKE_<LANG>_STANDARDproperties for setting the language standard and use generator expressions withadd_compile_optionsto remove the need for most of our uses ofCMAKE_CXX_FLAGS.Update our usage of
CMAKE_CXX_COMPILER_IDto correctly understand thatAppleClangis now distinct fromClang.