This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Optimize span clear #9598
Merged
Merged
Optimize span clear #9598
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
599507c
Optimizing Span.Clear using memset
ahsonkhan 61f9dfd
Addressing comments.
ahsonkhan 0fd6e9d
Removing commented out code.
ahsonkhan 49df9a7
Removing unnecessary casts to nuint.
ahsonkhan f435f72
Fixing namespace to System.Runtime
ahsonkhan 9a20c0d
Undoing unnecessary changes to sln file.
ahsonkhan c9c0dc0
Removing unnecessary ifdef.
ahsonkhan 05abafc
Addressing PR comments
ahsonkhan 7c27868
Adding Unsafe.Add that takes nuint instead of int32
ahsonkhan 703396b
Using BIT64 ifdefs to use ints instead of longs
ahsonkhan 34f5129
Fixing places where Add to AddNative was missed along with ifdef on B…
ahsonkhan ec6fb88
Changing AddNative to AddByteOffset
ahsonkhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.InteropServices; | ||
|
|
||
| #if BIT64 | ||
| using nuint = System.UInt64; | ||
| #else | ||
| using nuint = System.UInt32; | ||
| #endif | ||
|
|
||
| namespace System.Runtime | ||
| { | ||
| public class RuntimeImports | ||
| { | ||
| // Non-inlinable wrapper around the QCall that avoids poluting the fast path | ||
| // with P/Invoke prolog/epilog. | ||
| [MethodImplAttribute(MethodImplOptions.NoInlining)] | ||
| internal unsafe static void RhZeroMemory(ref byte b, nuint byteLength) | ||
| { | ||
| fixed (byte* bytePointer = &b) | ||
| { | ||
| RhZeroMemory(bytePointer, byteLength); | ||
| } | ||
| } | ||
|
|
||
| [DllImport(JitHelpers.QCall, CharSet = CharSet.Unicode)] | ||
| extern private unsafe static void RhZeroMemory(byte* b, nuint byteLength); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed offline, it might be good to understand why you're using these instead of UIntPtr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jkotas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is royal pain to do native size arithmetic using IntPtr/UIntPtr. We are using the same pattern in number of other places in CoreLib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(There is also discussion about getting better native integer arithmetic support in C#.)