This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Add GCWithHeap option to perfcollect #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sywhang thanks for doing this. Just saw this change in my inbox. Can you tell me what kind of testing you did on this? |
|
@brianrob I tested it on my local box to verify we're not getting the events we don't want on GCCollectOnly option as well as the new option I just added. One thing I wanted to ask you - do we have any automated tests for perfcollect? If so I'd like to know where/how to run it because I couldn't find it in this repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes GCJoin and PinObjectAtGCTime events from GCCollectOnly option.
For #65.
cc @noahfalk @brianrob @Maoni0