CoreFx test utility depends on Microsoft.DotNet.PlatformAbstractions

[weshaggard]

@krwq @tarekgh @eerhardt added a dependency on Microsoft.DotNet.PlatformAbstractions to CoreFx.TestUtilities in dotnet/corefx#24531. That cause a cycle in our build-from-source efforts so we have to figure out a solution to break that cycle.

For now I'm going to break the cycle by pinning to an existing version but we cannot do that in general because it requires us to have an existing binary which is bad for new-distro bring-up.

@eerhardt what is your thoughts on bring Microsoft.DotNet.PlatformAbstractions into corefx?

[weshaggard]

See dotnet/corefx@fa9fe16 for how I plan to pin it for now.

[eerhardt]

@eerhardt what is your thoughts on bring Microsoft.DotNet.PlatformAbstractions into corefx?

I would absolutely LOVE for this to happen.

However, I don't think it should go wholesale into corefx. I think pieces of it should be removed altogether (I'm looking at you HashCodeCombiner and Platform).

And some things should be folded into System.Runtime.InteropServices.RuntimeInformation, like RuntimeEnvironment.

ApplicationEnvironment can probably be deleted as well now that we have netstandard2.0. I'm not exactly sure what it's main purpose was - mostly for net45 and netstandard1.3 code to be able to call 1 method to get the BaseDirectory without having to #if themselves. With netstandard2.0, users can now call AppContext.BaseDirectory, or AppDomain.CurrentDomain.BaseDirectory for this.

So thinking about it more - probably move RuntimeEnvironment into RuntimeInformation, and delete the rest. Obviously the library will still live in servicing branches, if we ever need to service the already released versions of it. And users can continue to use the already released versions all they want.

[ghost]

[if former offsets the latter] maybe we can try to think it in light of the proposed API at https://github.com/dotnet/corefx/issues/27417 for public consumption when bringing over
https://github.com/dotnet/core-setup/tree/fd1dc48fad5bc32258c8c0fc885fbf4b1e32bebd/src/managed/Microsoft.DotNet.PlatformAbstractions to corefx?

[weshaggard]

Looks like we have a few issues that are tracking similar things https://github.com/dotnet/corefx/issues/16629, https://github.com/dotnet/corefx/issues/17452,
https://github.com/dotnet/corefx/issues/24522, https://github.com/dotnet/corefx/issues/25530, https://github.com/dotnet/corefx/issues/28132, https://github.com/dotnet/corefx/issues/23197

I hope we can tackle a number of them as part of moving these APIs into corefx.