Update CoreClr, CoreFx to beta-24509-03, beta-24509-01, respectively (master)

[dotnet-bot]

/cc @dotnet/corefx-contrib

[stephentoub]

@sepidehms, @shmao, there are a handful of failing tests in this PR, with the same tests failing across multiple legs. Can you please take a look?

 System.NullReferenceException : Object reference not set to an instance of an object.
        Stack Trace:
              at System.Xml.ValidateNames.ParseNmtoken(String s, Int32 offset)
              at System.Xml.XmlDocument.CheckName(String name)
              at System.Xml.XmlElement..ctor(XmlName name, Boolean empty, XmlDocument doc)
              at System.Xml.XmlDocument.CreateElement(String prefix, String localName, String namespaceURI)
              at System.Xml.XmlDocument.CreateElement(String name)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Runtime.Serialization.Xml\tests\DataContractSerializer.cs(2066,0): at DataContractSerializerTests.DCS_XmlElementAsRoot()

DataContractJsonSerializerTests.DCJS_XmlElementAsRoot [FAIL]
        System.NullReferenceException : Object reference not set to an instance of an object.
        Stack Trace:
              at System.Xml.ValidateNames.ParseNmtoken(String s, Int32 offset)
              at System.Xml.XmlDocument.CheckName(String name)
              at System.Xml.XmlElement..ctor(XmlName name, Boolean empty, XmlDocument doc)
              at System.Xml.XmlDocument.CreateElement(String prefix, String localName, String namespaceURI)
              at System.Xml.XmlDocument.CreateElement(String name)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Runtime.Serialization.Json\tests\DataContractJsonSerializer.cs(1820,0): at DataContractJsonSerializerTests.DCJS_XmlElementAsRoot()

 System.Xml.Tests.NodeInsertedTests.InsertNodeBefore [FAIL]
        System.NullReferenceException : Object reference not set to an instance of an object.
        Stack Trace:
           D:\j\workspace\windows_nt_re---37265eab\src\Common\src\System\Xml\ValidateNames.cs(42,0): at System.Xml.ValidateNames.ParseNmtoken(String s, Int32 offset)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlDocument\src\System\Xml\Dom\XmlDocument.cs(108,0): at System.Xml.XmlDocument.CheckName(String name)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlDocument\src\System\Xml\Dom\XmlElement.cs(19,0): at System.Xml.XmlElement..ctor(XmlName name, Boolean empty, XmlDocument doc)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlDocument\src\System\Xml\Dom\XmlDocument.cs(713,0): at System.Xml.XmlDocument.CreateElement(String prefix, String localName, String namespaceURI)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlDocument\src\System\Xml\Dom\XmlDocument.cs(492,0): at System.Xml.XmlDocument.CreateElement(String name)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlDocument\tests\XmlDocumentTests\NodeInsertedTests.cs(0,0): at System.Xml.Tests.NodeInsertedTests.InsertNodeBefore()

System.NullReferenceException : Object reference not set to an instance of an object.
        Stack Trace:
              at System.Xml.ValidateNames.ParseNmtoken(String s, Int32 offset)
              at System.Xml.XmlDocument.CheckName(String name)
              at System.Xml.XmlAttribute..ctor(XmlName name, XmlDocument doc)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XPath.XmlDocument\src\System\Xml\XmlDocumentEx.cs(18,0): at System.Xml.XmlDocumentEx.GetNamespaceXml(XmlDocument xmlDocument)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XPath.XmlDocument\src\System\Xml\DocumentXPathNavigator.cs(665,0): at System.Xml.DocumentXPathNavigator.MoveToNextNamespace(XPathNamespaceScope scope)
              at MS.Internal.Xml.XPath.NamespaceQuery.Advance()
              at MS.Internal.Xml.XPath.FilterQuery.Advance()
              at MS.Internal.Xml.XPath.MergeFilterQuery.Evaluate(XPathNodeIterator nodeIterator)
              at System.Xml.XPath.XPathNavigator.Evaluate(XPathExpression expr, XPathNodeIterator context)
              at System.Xml.XPath.XPathNavigator.Select(XPathExpression expr)
           D:\j\workspace\windows_nt_re---37265eab\src\Common\tests\System\Xml\XPath\Common\Utils.cs(40,0): at XPathTests.Common.Utils.CreateNavigator(String xml, String startingNodePath, XmlNamespaceManager namespaceManager)
           D:\j\workspace\windows_nt_re---37265eab\src\Common\tests\System\Xml\XPath\Common\Utils.cs(78,0): at XPathTests.Common.Utils.XPathObject[T](String xml, String testExpression, XmlNamespaceManager namespaceManager, String startingNodePath)
           D:\j\workspace\windows_nt_re---37265eab\src\Common\tests\System\Xml\XPath\CoreFunctionLibrary\StringFunctionsTests.cs(1064,0): at XPathTests.FunctionalTests.CoreFunctionLibrary.StringFunctionsTests.StringFunctionsTest2466()

System.InvalidOperationException : There is an error in XML document (12, 3).
        ---- System.NullReferenceException : Object reference not set to an instance of an object.
        Stack Trace:
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlSerializer\src\System\Xml\Serialization\XmlSerializer.cs(578,0): at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader xmlReader, String encodingStyle, Object events)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlSerializer\src\System\Xml\Serialization\XmlSerializer.cs(441,0): at System.Xml.Serialization.XmlSerializer.Deserialize(Stream stream)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlSerializer\tests\XmlSerializerTests.cs(2352,0): at XmlSerializerTests.SerializeAndDeserialize[T](T value, String baseline, Func`1 serializerFactory, Boolean skipStringCompare, XmlSerializerNamespaces xns)
           D:\j\workspace\windows_nt_re---37265eab\src\System.Xml.XmlSerializer\tests\XmlSerializerTests.cs(1271,0): at XmlSerializerTests.Xml_TypeWithXmlDocumentProperty()
           ----- Inner Stack Trace -----
              at System.Xml.ValidateNames.ParseNmtoken(String s, Int32 offset)
              at System.Xml.XmlDocument.CheckName(String name)
              at System.Xml.XmlElement..ctor(XmlName name, Boolean empty, XmlDocument doc)
              at System.Xml.XmlDocument.CreateElement(String prefix, String localName, String namespaceURI)
              at System.Xml.XmlDocument.ImportNodeInternal(XmlNode node, Boolean deep)
              at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderTypeWithXmlDocumentProperty.Read2_TypeWithXmlDocumentProperty(Boolean isNullable, Boolean checkType)
              at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderTypeWithXmlDocumentProperty.Read3_TypeWithXmlDocumentProperty()

Looks like they may all have the same root cause, as they all seem to involve ValidateNames.ParseNmtoken.

[shmao]

I debugged one of the failed tests, Xml_TypeWithXmlDocumentProperty. The test failed at this line due to the following exception,

Exception thrown: 'System.AccessViolationException' in system.xml.xmldocument.dll
{System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at System.Xml.ValidateNames.ParseNmtoken(String s, Int32 offset)}

None of the managed code files on the call stack has been changed recently. Could this be caused by some change in CoreCLR?

[stephentoub]

Could this be caused by some change in CoreCLR?

@jkotas, ring any bells?

[jkotas]

Bad codegen bug introduced by dotnet/coreclr#6889. I am going to submit rollback shortly.

@JosephTremoulet

[jkotas]

The fragments of good/bad code are at: https://gist.github.com/jkotas/c73468309c63754037375cb6aab7b1e4

[stephentoub]

Thanks, Jan!