-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Create FreeBSD build-target for corefx #2021
Conversation
37fd399
to
3de07fc
Compare
The changes to dir.props look good. The changes to System.Runtime.Environment.csproj are going to conflict with #1999 and would be better left for a separate PR that fully augments that library after the revised version is merged. |
858c9aa
to
cd631ce
Compare
This PR is getting slimmer and slimmer by the minute. :) I'll add the remaining bits once #1999 is merged. Seems like a small job and then we can start getting things done. |
😄 Could you just revert the System.Runtime.Environment.csproj file entirely? The commit still shows that whitespace-only changes were made to it. Even with it being a small change, it's a good first step, in that it'll allow you to build with |
This partially adresses https://github.com/dotnet/corefx/issues/1626
cd631ce
to
c57328e
Compare
Done and done. I had to actually work the command-line for that one, but I do agree that a good commit should only contain actually functional changes, so good thing somebody is keeping a watchful eye on me ;) |
LGTM 😄 |
Create FreeBSD build-target for corefx
Create FreeBSD build-target for corefx Commit migrated from dotnet/corefx@a764229
This partially addresses
https://github.com/dotnet/corefx/issues/1626