Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Move ManagedHandler version/chunking validation earlier #26766

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

stephentoub
Copy link
Member

Move it to ManagedHandler.SendAsync rather than HttpConnection.SendAsync so that it happens before we even try to get a connection. A minor benefit of the change as well is that isHttp10 is no longer lifted to the state machine.

Fixes https://github.com/dotnet/corefx/issues/26709
cc: @geoffkizer, @pjanotti

Move it to ManagedHandler.SendAsync rather than HttpConnection.SendAsync so that it happens before we even try to get a connection.  A minor benefit of the change as well is that isHttp10 is no longer lifted to the state machine.
@geoffkizer
Copy link

LGTM

@stephentoub
Copy link
Member Author

@dotnet/dnceng, FYI:
https://ci3.dot.net/job/dotnet_corefx/job/master/job/windows-TGroup_netcoreapp+CGroup_Release+AGroup_x86+TestOuter_false_prtest/7830/

D:\j\workspace\windows-TGrou---f8ac6754\Tools\CloudTest.Helix.targets(216,5): warning : An error occurred while sending the request. [D:\j\workspace\windows-TGrou---f8ac6754\src\upload-tests.proj]
D:\j\workspace\windows-TGrou---f8ac6754\Tools\CloudTest.Helix.targets(216,5): warning :    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) [D:\j\workspace\windows-TGrou---f8ac6754\src\upload-tests.proj]
D:\j\workspace\windows-TGrou---f8ac6754\Tools\CloudTest.Helix.targets(216,5): warning :    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) [D:\j\workspace\windows-TGrou---f8ac6754\src\upload-tests.proj]
D:\j\workspace\windows-TGrou---f8ac6754\Tools\CloudTest.Helix.targets(216,5): warning :    at Microsoft.DotNet.Build.CloudTestTasks.AzureHelper.<RequestWithRetry>d__13.MoveNext() [D:\j\workspace\windows-TGrou---f8ac6754\src\upload-tests.proj]

@dotnet-bot test Windows x86 Release Build please

@stephentoub stephentoub merged commit bb738a0 into dotnet:master Feb 2, 2018
@stephentoub stephentoub deleted the fixsettings branch February 2, 2018 01:15
@karelz karelz added this to the 2.1.0 milestone Feb 4, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…x#26766)

Move it to ManagedHandler.SendAsync rather than HttpConnection.SendAsync so that it happens before we even try to get a connection.  A minor benefit of the change as well is that isHttp10 is no longer lifted to the state machine.

Commit migrated from dotnet/corefx@bb738a0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants