Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/2.1] Revert - Ensure ConcurrentBag's TryTake is linearizable #31132

Merged
merged 1 commit into from
Jul 18, 2018
Merged

[release/2.1] Revert - Ensure ConcurrentBag's TryTake is linearizable #31132

merged 1 commit into from
Jul 18, 2018

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Jul 17, 2018 •
edited by karelz
Loading

Reverts PR #31009

Pulling this temporarily as it missed 2.1.3 and they want a clean branch in case they need to rebuild 2.1.3 for some reason.

Just hit "revert" button.

@danmoseley
Copy link
Member Author

danmoseley commented Jul 17, 2018 •
edited by karelz
Loading

Issue #30781

@danmoseley
Copy link
Member Author 

/mnt/j/workspace/dotnet_corefx/release_2.1/linux-TGroup_netcoreapp+CGroup_Release+AGroup_arm64+TestOuter_false_prtest/Tools/Symbols.targets(515,7): warning : Downloading https://dotnetfeed.blob.core.windows.net/dotnet-core/assets/symbols/runtime.linux-arm64.Microsoft.NETCore.Runtime.CoreCLR.2.1.3-servicing-26708-02.symbols.nupkg failed with exception:  [/mnt/j/workspace/dotnet_corefx/release_2.1/linux-TGroup_netcoreapp+CGroup_Release+AGroup_arm64+TestOuter_false_prtest/external/runtime/runtime.depproj]

@stephentoub stephentoub changed the title Revert "[release/2.1] Ensure ConcurrentBag's TryTake is linearizable (#30947)" [release/2.1] Ensure ConcurrentBag's TryTake is linearizable" Jul 18, 2018
@stephentoub
Copy link
Member

@dotnet-bot test this please

@stephentoub stephentoub changed the title [release/2.1] Ensure ConcurrentBag's TryTake is linearizable" [release/2.1] Ensure ConcurrentBag's TryTake is linearizable Jul 18, 2018
@danmoseley
Copy link
Member Author

Failure is very unlikely to be related and I want to get branch back in good state.

@danmoseley danmoseley merged commit 778a21f into release/2.1 Jul 18, 2018
@danmoseley danmoseley deleted the revert-31009-port30947 branch July 18, 2018 20:13
@danmoseley danmoseley mentioned this pull request Jul 18, 2018
Merged
@karelz karelz added this to the 2.1.x milestone Jul 19, 2018
@stephentoub stephentoub mentioned this pull request Jul 19, 2018
Merged
@karelz karelz changed the title [release/2.1] Ensure ConcurrentBag's TryTake is linearizable [release/2.1] Revert - Ensure ConcurrentBag's TryTake is linearizable Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.Collections
Projects
None yet
Milestone
2.1.x
Development

Successfully merging this pull request may close these issues.
3 participants
@danmoseley @stephentoub @karelz