This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Ensure we generate version prop before sync parallel build #31137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to generate the buildversion props file before we start a parallel build otherwise we race condition that can break the build.
The TraversalBuildDependsOn gets other things added to it like BuildAllProjects which we don't want for the Sync target so factoring out the common pre-steps and sharing just those with sync and build.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…nPropsForSync-m Ensure we generate version prop before sync parallel build Commit migrated from dotnet/corefx@20ac3b1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to generate the buildversion props file before we start
a parallel build otherwise we race condition that can break
the build.
cc @mmitche Port change #31097 to master.