This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Test a couple of fixes for apartment state issues related to enabling tiered jitting #31822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouvel
force-pushed
the
TierPost22
branch
3 times, most recently
from
23e002c to
892fb78
Compare
Partial port of dotnet#31682 to 2.2 Tests for dotnet/coreclr#19384 Related to https://github.com/dotnet/coreclr/issues/17822 Related to https://github.com/dotnet/coreclr/issues/17787 Related to https://github.com/dotnet/coreclr/issues/19225
noahfalk
approved these changes
Aug 28, 2018
danmoseley
changed the title
|
Please do not merge until dotnet/coreclr#19691 is consumed by CoreFX |
danmoseley
added
Servicing-approved-2.1.5
and removed
Servicing-consider
|
approved by big shiproom |
kouvel
added a commit
to dotnet/coreclr
that referenced
this pull request
Aug 30, 2018
This is a port of several changes that went into master after 2.2 forked, including dependencies for, and enabling tiered compilation by default in 2.2. Quick summary of commits is below, see the commit descriptions and PRs for more info. - Commit 1 - Fix nested spin locks in thread pool etw firing (#17677) - Fixes a lock nesting issue when there is an ETW listener, which can occur without tiering, but is almost deterministic with tiering enabled because the first event that is fired typically hits this code path - Commit 2 - Don't close the JIT func info file on shutdown (#18060) - Fixes a crash during shutdown that only occurs when JIT logging is enabled (typically in the coreclr tests and CI). More frequent with tiering enabled because of different JIT timing and background jitting. - Commit 3 - Apply tiering's call counting delay more broadly (#18610) - Fixes a perf issue when tiering is enabled in server first-request scenarios where there is a significant gap between process startup and first request - Commit 4 - Changes only affect debug builds - Eliminate arm64 contract asserts (#19015) - Fixes some incorrect asserts that trigger more frequently with tiering - Commit 5 - Use 16 bytes to spill SIMD12 (#19237) - Fixes a crash in corefx System.Numerics.Tests.Vector3Tests.Vector3EqualsTest. Occurs with minopt JIT or with tiering. - Commit 6 - Fix an apartment state issue (partial port of #19384) - This is a partial port of this PR (only the portion that addresses issue #17822) - This is a breaking change, though a minor one that we have concluded is an acceptable risk to take for 2.2 - Fixes a behavioral difference that can be seen more easily tiering enabled in APIs on the `Thread` class relevant to apartment state. The issue can also be seen in some cases when tiering is disabled. - Commit 7 - Enable Tiered Compilation by default (#19525) - Enables tiering by default, can be disabled through environment, or through .csproj/.json when using dotnet - Removes deprecated config variable (EXPERIMENTAL_TieredCompilation) that was previously exposed in 2.1 along with the current config variable (TieredCompilation), along with miscellaneous test fixes - Commit 8 - Changes only affect tests - Fix tiered compilation option for case-sensitive systems (#19567) - Fixes tiering environment variable casing for non-Windows platforms - Commit 9 - Disable tiered compilation on arm64 - There is an open issue that may be partly related to minopts on arm64 (https://github.com/dotnet/coreclr/issues/18895). Disabling tiering by default on arm64 to limit exposing new issues. This change would be followed up with dotnet/corefx#31822 - Adds tests for Commit 6 - Fix an apartment state issue (partial port of #19384) - Changes only affect tests Closes https://github.com/dotnet/coreclr/issues/18973
|
feel free to merge when ready. |
|
@dotnet-bot test Windows x64 Debug Build |
1 similar comment
|
@dotnet-bot test Windows x64 Debug Build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dotnet/coreclr#19691
Port of #31682 to 2.2. Changes only affect tests.
Tests for dotnet/coreclr#19384 (for the portion of which is ported as part of enabling tiering)
Related to dotnet/coreclr#17822
Related to dotnet/coreclr#17787
Related to dotnet/coreclr#19225