This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix interop for RTL_OSVERSIONINFOEX #32433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure that the OS version string is marshaled as Unicode - Avoid allocating the version string when it is not needed Fixes #32423
stephentoub
approved these changes
Sep 24, 2018
ViktorHofer
reviewed
Sep 24, 2018
| [StructLayout(LayoutKind.Sequential)] | ||
| private struct RTL_OSVERSIONINFOEX | ||
| [StructLayout(LayoutKind.Sequential, CharSet=CharSet.Unicode)] | ||
| private unsafe struct RTL_OSVERSIONINFOEX |
There was a problem hiding this comment.
Why don't we include src/Common/src/Interop/Windows/NtDll/Interop.RTL_OSVERSIONINFOEX.cs to avoid the duplication here?
There was a problem hiding this comment.
This file has duplicate local interop definitions for everything it calls - CloseHandle, GetCurrentProcess, ... . I do not know why it was done this way. If there is a good reason to clean it up, it should be separate PR.
There was a problem hiding this comment.
|
Unrelated UWP failure |
ViktorHofer
added a commit
that referenced
this pull request
Sep 24, 2018
This reverts commit 1a7ef6f.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
- Ensure that the OS version string is marshaled as Unicode - Avoid allocating the version string when it is not needed Fixes dotnet/corefx#32423 Commit migrated from dotnet/corefx@1a7ef6f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32423