This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Bump S.S.C.Pkcs AssemblyVersion Minor version #35429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New API was added for .NET Core 3.0, so the assembly minor needs to bump.
|
I suspect you need a packageindex change with this. |
|
Looks like you've also got validation issues. One problem I see is you're building the netstandard implementations with the higher assembly version. There may be others. |
ericstj
reviewed
Feb 20, 2019
| @@ -2,7 +2,8 @@ | |||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="..\Directory.Build.props" /> | |||
| <PropertyGroup> | |||
| <AssemblyVersion>4.0.4.0</AssemblyVersion> | |||
| <AssemblyVersion>4.1.0.0</AssemblyVersion> | |||
| <NetstandardAssemblyVersion>4.0.4.0</NetstandardAssemblyVersion> | |||
There was a problem hiding this comment.
You could have done <AssemblyVersion Condition="'$(TargetsNetStandard)' == 'true'">4.0.4.0</AssemblyVersion> here, depending on what makes the most sense to you.
There was a problem hiding this comment.
Consider adding a comment here that says something like netstandard API surface is still 4.0.* since that is all that is supported by desktop.
There was a problem hiding this comment.
Ah, okay, I'll try that, since it reduces the places that can get it wrong.
ericstj
approved these changes
Feb 20, 2019
ericstj
approved these changes
Feb 20, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Bump S.S.C.Pkcs AssemblyVersion Minor version New API was added for .NET Core 3.0, so the assembly minor needs to bump. * Fix packaging validation errors * Apply review feedback Commit migrated from dotnet/corefx@b4f94ab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API was added for .NET Core 3.0, so the assembly minor needs to bump.
Fixes #35160.