Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Re-enable some Http Diagnostic tracing tests #37286

Closed
wants to merge 1 commit into from
Closed

Re-enable some Http Diagnostic tracing tests #37286

wants to merge 1 commit into from

Conversation

davidsh
Copy link
Contributor

@davidsh davidsh commented Apr 30, 2019

Some of these tests were disabled a long time ago and only on Linux.
Since that time, the tests were improved.

I re-enabled the tests plus some others that appear to be stable now.

Closes #23209
Closes #23771

Re-enable some Http Diagnostic tracing tests
37cb831 
Some of these tests were disabled a long time ago and only on Linux.
Since that time, the tests were improved.

I re-enabled the tests plus some others that appear to be stable now.

Closes #23209
Closes #23771
@davidsh davidsh added this to the 3.0 milestone Apr 30, 2019
@davidsh davidsh self-assigned this Apr 30, 2019
@davidsh
Copy link
Contributor Author

davidsh commented Apr 30, 2019

/azp run corefx-outerloop-windows

@davidsh
Copy link
Contributor Author

davidsh commented Apr 30, 2019

/azp run corefx-outerloop-linux

@davidsh
Copy link
Contributor Author

davidsh commented Apr 30, 2019

/azp run corefx-outerloop-osx

@dotnet dotnet deleted a comment from azure-pipelines bot Apr 30, 2019
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 30, 2019
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 30, 2019
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 30, 2019
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 30, 2019
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 30, 2019
@davidsh davidsh requested review from stephentoub and a team April 30, 2019 01:34
@davidsh
Copy link
Contributor Author

davidsh commented Apr 30, 2019

/azp run corefx-outerloop-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

wfurt
wfurt approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We can watch it for a while and instrument it if it starts failing again.

@davidsh
Copy link
Contributor Author

davidsh commented Apr 30, 2019 •
edited
Loading

We can watch it for a while and instrument it if it starts failing again.

The Outerloop Linux test results are really strange. There are a lot of failures beyond just some of the few Diagnostic tests I re-enabled. Some HTTP/2 tests are failing. Alpine is the biggest problem.

Is there some other problem happening?
https://mc.dot.net/#/user/dotnet-bot/pr~2Fdotnet~2Fcorefx~2Frefs~2Fpull~2F37286~2Fmerge/test~2Ffunctional~2Fcli~2F~2Fouterloop~2F/20190429.7/workItem/System.Net.Http.Functional.Tests

image

@davidsh
Copy link
Contributor Author

davidsh commented May 1, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@davidsh
Copy link
Contributor Author

davidsh commented May 1, 2019

It seems turning on these diagnostics tests is causing a bunch of other, non-related, Http tests to generate TimeoutException.

@davidsh davidsh added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label May 1, 2019
@stephentoub
Copy link
Member

@davidsh, what should happen with this PR? Thanks.

@davidsh davidsh closed this Jun 3, 2019
@davidsh davidsh deleted the http_diag_tests branch June 3, 2019 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@davidsh davidsh

Labels
area-System.Net.Http * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Milestone
3.0
3 participants
@davidsh @stephentoub @wfurt