This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Removing Microsoft.bcl* packages #41270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
reviewed
Sep 23, 2019
ViktorHofer
reviewed
Sep 23, 2019
ViktorHofer
reviewed
Sep 23, 2019
ViktorHofer
reviewed
Sep 23, 2019
ViktorHofer
reviewed
Sep 23, 2019
ericstj
reviewed
Sep 23, 2019
ViktorHofer
reviewed
Sep 24, 2019
|
@ericstj @ViktorHofer is there something else that needs to be done here ? |
|
I'd like @ahsonkhan to sign off on the Json change. |
ericstj
approved these changes
Sep 25, 2019
ericstj
reviewed
Sep 25, 2019
ahsonkhan
reviewed
Sep 25, 2019
|
@ericstj @ahsonkhan I addressed the feedback |
ViktorHofer
reviewed
Sep 26, 2019
|
@ericstj @ViktorHofer can you give a final review here ? |
ViktorHofer
reviewed
Oct 2, 2019
|
@ViktorHofer @ericstj I added the choose when statement |
ericstj
reviewed
Oct 2, 2019
ericstj
reviewed
Oct 2, 2019
|
@ericstj is it good to merge this one ? |
ericstj
approved these changes
Oct 4, 2019
mmitche
added a commit
to mmitche/Extensions
that referenced
this pull request
Oct 17, 2019
This is no longer produced by corefx as of dotnet/corefx#41270
ericstj
reviewed
Jan 23, 2020
| <Version>4.5.2</Version> | ||
| </PackageReference> | ||
|
|
||
| <PackageReference Include="System.Memory" Version="4.5.2" Condition="'$(TargetFramework)' == 'netcoreapp2.0' OR '$(TargetFramework)' == 'uap10.0.16299' OR '$(TargetsNetfx)' == 'true' OR ('$(TargetsNetStandard)' == 'true' AND '$(NETStandardVersion)' >= 1.1)" /> |
There was a problem hiding this comment.
Looks like this regressed System.Memory ref, discovered here: dotnet/sdk#3884
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* removing Microsoft.bcl packages * targetframework conditions modified * adding versionless config to avoid binplace * uap standard conflicts * remove package configurations * negation if and remove exclude reference asset property * adding choosing when statement * using attribute * Moveing packages to include to the common * ChooseWhen -> IF Commit migrated from dotnet/corefx@99ea2b5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.