This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] JsonSerializer.Serialize should check whether the passed-in Utf8JsonWriter is null. #42027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2026) Utf8JsonWriter is null.
|
Unrelated test failure on |
steveharter
approved these changes
Oct 23, 2019
|
@danmosemsft - what are your thoughts on this? |
ericstj
approved these changes
Oct 23, 2019
danmoseley
added
Servicing-approved
|
Approved. This is marginal, since the impact is low. However it's very low risk and increases the consistency of this new API. |
|
@ahsonkhan confirmed offline that this is definitely going to throw already in this codepath. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #42026
Description
Add null checks for the
Utf8JsonWriterargument being passed in to the JsonSerializer.Serialize overloads.Customer Impact:
Instead of user potentially seeing a
NullReferenceException, they now get a more friendlyArgumentNullException. I'd put this type of fix in general reliability improvement.Regression?
No
Risk
Low. The change is really straight forward (basic argument validation and moving to a user-friendly exception). No one should be depending on
NullReferenceException.Tests run / added
Basic test added.
cc @steveharter, @ericstj, @danmosemsft