This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Remove TryGetPointer from RioTcpConnection #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that looks good /cc @davidfowl |
|
@KodrAus You need to call Free so the ref count doesn't just go up forever. |
|
@davidfowl Derp. Fixed. That's a nice segway into there are no tests for any of this code. Looks like the |
davidfowl
reviewed
Mar 28, 2017
| @@ -116,6 +116,23 @@ public IntPtr GetBufferId(IntPtr address, out long startAddress) | |||
| return id; | |||
| } | |||
|
|
|||
| public unsafe RioBufferSegment GetSegmentFromMemory(Buffer<byte> memory) | |||
| { | |||
| var pin = memory.Pin(); | |||
There was a problem hiding this comment.
Add a comment about why it's ok to unpin here because the memory needs to be pinned already? How do we enforce that though? There's no way to know if the backing memory is already pinned...
There was a problem hiding this comment.
But since we create the pool, it's ok. Just add the comment and I'll merge it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1298
Moves the
GetSegmentFromMemorymethod into theRioThreadand usesPininstead ofTryGetPointer. I think it's safe to not keep theMemoryHandlearound because we verify the memory is from aSlabin the memory pool using its address, which we know is pinned.So now it's
RioThreads responsibility to make sure its buffers are pinned, which is better because it's the one creating theMemoryPool.I'm not sure about error handling, if it turns out the memory isn't from a known slab then the RIO buffer id is
IntPtr.Zero, but we're not explicitly dealing with this.