This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Add per-platform ANSI art to HelloWorld #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good |
stephentoub
added a commit
that referenced
this pull request
Feb 3, 2015
Add per-platform ANSI art to HelloWorld
Merged
danmoseley
pushed a commit
that referenced
this pull request
Nov 17, 2018
* RefDictionary start * style fixes * add first perf test * small style fixes, more sizes * further review * capacity need to be power of 2 for som reason * bit faster by reordering fields * refdictionary add knucleotide perf tests * fix size power of 2 bug * groupby performance test * add Values and other method * IEquatable<T> FTW * resize improvements and more tests * simplify enumerator * small insert changes * add isfasterthan test * remove old baseline version * split out Resize() * prime, capacity, inline and rename to DictionarySlim * latest knucleotide, comments * Primize capacity * Calculate hash only once * Update Hack to #9 * Remove impl * By ref in indexer * merge tests * remove FSharp reference * de var * Revert "By ref in indexer" This reverts commit d26e0fd. * remove for value types * general test data, test knucleotide result general test data, test knucleotide result * uint with better perf * fasta license * add simple DebugView * move usings, simplify Capacity, move assign in resize * complete remove, add copyto * reduce bounds checking * split indexer for better perf * initial arrays, enumerate tests * remove perf test * add collision loop detection * Resource strings for concurrency error * Enable errors in HashHelpers * Extract dummy arrays into class * nested enumerator, only int initial array shared more * fix initial buckets * aghh fixed correctly now * Improve CopyTo tests * Avoid boxing on GetEnumerator() * Make namespace match MultiValueDictionary * Fix benchmark on Linux * Minor spacing * NuGet keyword, version * Remove dead strings * Implement IC and IROC on K/V enumerators * Ensure BDN diagnostics dll loads * Disable slow running benchmarks by default * Cherry pick BDN version update * Break out HashHelpers * Test that Remove releases ref * Extract local * Extract local in enumerators * Server Concurrent GC * Modulo over buckets length * remove old sign bit comment * don't auto prop Count * Debugger display * static GetHashCode * manually inline methods * Remove Current autoproperty * rename KeyEnumerable to KeyCollection, same for Value * Make IsReadOnly explicitly implemented * Add TryGetValue * Change KNuc to TryGetValue * KNuc: Sum over values directly * Break out field initialization * add throwhelper and null argument exceptions * try power 2 with & (length-1) * remove by moving last instead of freeList * collisionCount down * check capacity * check capacity * Revert "collisionCount down" This reverts commit 8538069. * add string perf plus mix up others * add ctor and remove tests * revert 'remove by moving last instead of freeList' * revert 'remove by moving last instead of freeList' * Validate CopyTo array * Implicit impl for CopyTo and Reset on enumerators matching Dictionary * Handle capacity 0 and 1 * Corruption protection on Remove() * Protect against capacity overflow * Remove GetValueOrDefault * Change indexer to GetOrAddValueRef
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just by looking at the code you can likely guess what gets drawn for Linux ;)
I've left Mac as a todo for someone else who'd like to contribute something beautiful.
Right now, the console app just takes the target platform as a command-line argument. We can update it later to fall back to a default based on Environment.